Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of other fields #5056

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Fix order of other fields #5056

merged 1 commit into from
Jun 16, 2019

Conversation

CyraxSector
Copy link
Contributor

@CyraxSector CyraxSector commented Jun 15, 2019 •
edited by Siedlerchr
Loading

Fixes #5028

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@CyraxSector CyraxSector mentioned this pull request Jun 15, 2019
Closed
@Siedlerchr
Copy link
Member

Thanks for your contribution. Could you please adjust your title of the PR and describe how/ or why the fix works?
Thanks in advance

tobiasdiez
tobiasdiez approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I think the fix works as intended. As @Siedlerchr said, it would be nice if you could add a bit of context to the PR description the next time.

@CyraxSector
Copy link
Contributor Author

@tobiasdiez sure I'll add comment descriptions for the next PRs. BTW I cannot merge this PR. Any reason?

@Siedlerchr
Copy link
Member

Only members of the core JabRef development team are able to merge PRs. This is normal for most github organizations/projects.
Each PR should ideally be reviewed by at least two JabRef core developers to maintain a high quality of the code base.

@CyraxSector
Copy link
Contributor Author

@Siedlerchr sure. I thought the reason might be something like a CI build failure or any.

@Siedlerchr Siedlerchr changed the title bugfix/5028 :Initial commit. Fix order of other fields Jun 16, 2019
@Siedlerchr Siedlerchr merged commit e74a954 into JabRef:master Jun 16, 2019
github-actions bot pushed a commit that referenced this pull request Nov 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 5297abd..5c376b8
0702648 
5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (#5083)
6a62c24 Create ucl-institute-of-education-harvard.csl (#5084)
4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (#5073)
3a9f494 Update cureus.csl (#5087)
181c0dd Create apa-no.csl (#5059)
651ce48 Some fixes for Advanced Functional Materials (#5080)
4e3297a Acta Zoologica Hungarica: Don't demote nd particles
c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (#5078)
d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (#5079)
1ee3809 Update mcgill-en.csl (#5076)
949cdc6 Update mcgill-fr.csl (#5075)
ee7d4e1 Create chem-catalysis.csl (#5074)
ec9faec Switch Molecular Therapy to Cell (#5070)
cf6034c Switch Elsevier to their own ad-vancouver (#5072)
78cca13 Updates in research-institute-for-nature-and-forest.csl (#4958)
68b7478 Update journal-of-neolithic-archaeology.csl (#5065)
524ba93 Create offa.csl (#5066)
9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (#5067)
44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (#5061)
baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (#5064)
c5c3531 Fix CORR
853a804 Major Update mcgill-fr.csl to 9th ed. (#5057)
d3e2cd9 Update mcgill-en.csl (#5056)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5c376b8
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Nov 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 5297abd..55200d0
188e1e3 
55200d0 Create computational-intelligence.csl (JabRef#5102)
6d2efc3 Merge branch 'master' of github.com:citation-style-language/styles
60ab0fb Add Steinbeis SMI
d5e0130 Add AAQR Style
d964f9b Create bitonline-publikationen.csl (JabRef#5090)
0dc1a56 Add "APA 7th edition" to Norsk APA style titles (JabRef#5098)
3b6aaf7 Update norsk-apa-manual.csl (JabRef#5095)
0139c63 Create technische-universitat-dresden-betriebswirtschaftslehre-rechnungswesen-controlling.csl (JabRef#5034)
fdc4497 Update universidade-estadual-de-alagoas-abnt (JabRef#5085)
afdc2ea Create revista-espanola-de-nutricion-humana-y-dietetica.csl (JabRef#5082)
939189d Create citation-compass-apa-note-no.csl (JabRef#5060)
414f5e6  brazilian-journal-of-veterinary-research: add bib sorting (JabRef#5091)
dbae9d7 Add DOI to Thieme German
f4399aa APA: match="any" bugfixes (JabRef#5092)
d0cc2c4 Add APA numeric and update BioEssays (JabRef#5089)
5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (JabRef#5083)
6a62c24 Create ucl-institute-of-education-harvard.csl (JabRef#5084)
4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (JabRef#5073)
3a9f494 Update cureus.csl (JabRef#5087)
181c0dd Create apa-no.csl (JabRef#5059)
651ce48 Some fixes for Advanced Functional Materials (JabRef#5080)
4e3297a Acta Zoologica Hungarica: Don't demote nd particles
c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (JabRef#5078)
d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (JabRef#5079)
1ee3809 Update mcgill-en.csl (JabRef#5076)
949cdc6 Update mcgill-fr.csl (JabRef#5075)
ee7d4e1 Create chem-catalysis.csl (JabRef#5074)
ec9faec Switch Molecular Therapy to Cell (JabRef#5070)
cf6034c Switch Elsevier to their own ad-vancouver (JabRef#5072)
78cca13 Updates in research-institute-for-nature-and-forest.csl (JabRef#4958)
68b7478 Update journal-of-neolithic-archaeology.csl (JabRef#5065)
524ba93 Create offa.csl (JabRef#5066)
9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (JabRef#5067)
44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#5061)
baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (JabRef#5064)
c5c3531 Fix CORR
853a804 Major Update mcgill-fr.csl to 9th ed. (JabRef#5057)
d3e2cd9 Update mcgill-en.csl (JabRef#5056)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 55200d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entry Editor: "Other fields"
3 participants
@CyraxSector @Siedlerchr @tobiasdiez