Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloading pdf produces html as extension #4965

Merged
merged 5 commits into from
May 18, 2019
Merged

Fix downloading pdf produces html as extension #4965

merged 5 commits into from
May 18, 2019

Commits on May 11, 2019

  1. Fix downloading pdf produces html as extension 

    If we already have a filetype we use that instead of relying on the autodetection


Fixes #4913
    @Siedlerchr
    Siedlerchr committed May 11, 2019
    Configuration menu
    Copy the full SHA
    d3ce2e2 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Merge remote-tracking branch 'upstream/master' into fileURlfix 

    * upstream/master:
  Revised README.md (#4974)
  Switch Jsoup's StringUtil for JabRef's StringUtil (#4970)
  Remove UI ThreadList for maintable as it prevents sorting in maintable (#4964)
  fix map collision (#4962)
    @Siedlerchr
    Siedlerchr committed May 17, 2019
    Configuration menu
    Copy the full SHA
    888aa6f View commit details
    Browse the repository at this point in the history

  2. add relativze if not an URL

    @Siedlerchr
    Siedlerchr committed May 17, 2019
    Configuration menu
    Copy the full SHA
    bd016c1 View commit details
    Browse the repository at this point in the history

  3. Create Test for download pdf document 

    heavy mocking and refactoring of ExternalFileType

TODO : Cleanup
    @Siedlerchr
    Siedlerchr committed May 17, 2019
    Configuration menu
    Copy the full SHA
    c21c0f8 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. refactor and simply test 

    fix cehckstyle
fail test on exception
    @Siedlerchr
    Siedlerchr committed May 18, 2019
    Configuration menu
    Copy the full SHA
    adfa4a4 View commit details
    Browse the repository at this point in the history