Rework import inspection dialog in JavaFX

[tobiasdiez]

• Rework dialog in JavaFX
• Unify code for import (move everything from the old import dialog class to the import handler)
• Simply interface and reduce user-choices (in particular, always generate bibtex keys)

There are still a few todo's related to undo/redo functionality (which is a further huge PR). Moreover, I'm not sure if I correctly transferred the handling of duplicated entries (the code was a bit hard to understand at some places).

@MartinKarim Any suggestions to (further) improve the UI? I tried to highlight the entries which the user selected for import (by clicking the plus icon), but that looked ugly and was in conflict to mouse over and mouse clicked states of the list rows.

Before:

After:

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[Siedlerchr]

that brace position looks odd

[Siedlerchr]

Is there no way to bind it to a property in the viewModel?

[Siedlerchr]

Why don't you reuse the previewPanel? It has been designed to be used for such cases.

[tobiasdiez]

The PreviewPanel just displays HTML, which makes it hard to enrich the display with further functionality (such as the "more" button to expand the abstract). In the longterm I would actually propose to remove the PreviewPanel in favor of JavaFX controls.

[Siedlerchr]

Inject preferencesService in the View and use it here

[Siedlerchr]

See comments. But in general, huge effort!

[Siedlerchr]

Is there a reason why you removed GENERATE_KEYS_AFTER_INSPECTION ?

[tobiasdiez]

Yes, the keys are now always generated so there is no need to have preference toggle for it.

[MartinKarim]

I would choose a simple click on the list entry the action to select the entry, which involves a change of background color. If the user then clicks on another entry, it becomes selected as well, while the first entry does not get deselected (see bottom). This would cause the whole list to be in a kind of selection mode, where clicking on an entry toggles its selection state, but does not deselect other entries in the process.
I think that mode of interaction is possible because selecting an entry is the only action that can be taken in that view if I am correct, except for clicking a button or expanding an entry.
This would have multiple advantages:

1. Changing the color on the whole entry would give the user more feedback than just coloring the circle with the plus sign.
2. It is easier to mark an entry, because the area for clicking is increased.
3. The process is easy to revert, if an entry is marked by accident.

Additionally, I would make the buttons to select/deselect entries more noticable by either making them elevated with color or by moving them to the middle of the list or even both. Right now, they are a bit overshadowed by the information above them.

[matthiasgeiger]

I support the idea of @MartinKarim. Additionally I would suggest to have a small label above the entry list stating: "Select the entries to be imported:"

[Siedlerchr]

@MartinKarim That is possible, Lists and Table typically support Multiple and Single selection mode.
Like in the file manager (e.g. Windows explorer), holding shift or pressing CTRL enables selection multiple entries
I think this is also the current behavior for the main table

[matthiasgeiger]

I think the multi selection aka 'ctrl' behavior should be default without the need to hold the key pressed in order to have a good usability.

[tobiasdiez]

Thanks for the valuable feedback. I now implemented most of it:

The text buttons at the bottom still need to be improved, but since this applies to every text-based button I leave this to a new PR.