[WIP] Drastically! Improve performance #4578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
changed the title
tobiasdiez
requested changes
Feb 9, 2019
| @@ -166,7 +123,7 @@ private void openWindow(Stage mainStage) { | |||
|
|
|||
| for (ParserResult pr : failed) { | |||
| String message = Localization.lang("Error opening file '%0'.", pr.getFile().get().getName()) + "\n" | |||
| + pr.getErrorMessage(); | |||
| + pr.getErrorMessage(); | |||
There was a problem hiding this comment.
The rest of the code should also be moved to run async because it relies on opening the last opened files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt at hacking the performance of JabRef at startup
I found out that JabRef sequentially loads the last edited files in the GUI thread.
Now I decided to load multiple databases in parallel and in a background task.
This drastically improves the startup performance.
This is currently more a good hack. But maybe @tobiasdiez you have some ideas on how to make it fine.
Seems that I currently are stuck with an open thread at exiting JabRef