Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArXiv fetcher support http url #4367

Merged
merged 3 commits into from
Oct 10, 2018
Merged

Conversation

zesaro
Copy link
Contributor

@zesaro zesaro commented Oct 9, 2018

In this PR I wanted to fix the issue from koppor#328.
I simply used existing code in the same file which just takes the identifier at the end of the URL and perform a search.

For example: https://arxiv.org/abs/1802.01168 to 1802.01168

The error dialog does not appear anymore and a new entry is made.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. The code looks good to me. Can you please add a changelog entry and a test analogous to

@Test
public void searchEntryByIdWith4Digits() throws Exception {
assertEquals(Optional.of(sliceTheoremPaper), finder.performSearchById("1405.2249"));
}

@Siedlerchr
Copy link
Member

Yeah, looks good to me! I exactly had the same issue yesterday that I could not paste the whole url

@tobiasdiez tobiasdiez merged commit 0a55a82 into JabRef:master Oct 10, 2018
@zesaro zesaro deleted the fix/koppor328 branch October 10, 2018 08:34
Siedlerchr added a commit that referenced this pull request Oct 13, 2018
* upstream/master:
  Update Libraries (#4366)
  ArXiv fetcher support http url (#4367)
  Fix issue 3861 : XMP Dialog, Add new Groups dialog, Append Library dialog to javafx (#4264)
  fix IndexOutOfBoundsException when saving preferences
  group RadioButtons in ExportSortingPrefsTab to prevent the selection of multiple or no order types
  Convert Part of the Issue#3861 Quality->Cleanup entries (#4268)
  UPDATE gradle to 4.10.2 (#4358)
  Completed General Fields Customizer conversion to JavaFX (#4346)
  Fix JavaFX thread exception when fetching new infos (#4354)
  Auto trim url field (#4355)
  Fix freezes in entry editor (#4351)

# Conflicts:
#	src/main/java/org/jabref/preferences/PreferencesService.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants