-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework entry editor toolbar in JavaFX #3427
Conversation
To be honest I do not really use that left toolbar, but in general I appreciate the layout. I typically use generate bibtex key on the main table |
Your comment about the bugs in the entry editor would be funny if I wouldn't suspect that you are actually serious about that ;-) This PR is the logical next step in the JavaFX migration. Most of the entry editor is in FX now, so this should be as well. Your arguments regarding button placement are reasonable and you have my Go for most of it. I think the XMP-generation button is fine at the file field, but maybe @koppor (who actually uses the feature) disagrees and wants to keep it? Your main challenge will probably be to make sure that the file field does not get too cramped with all the buttons. Personally, I don't see why the help button should go. Does it make the toolbar so much more ugly? There's one thing with the buttons in all of the entry editor that you could address here: The button icons do not follow the color scheme of JabRef, but are always black. Could you align that to the color scheme? Code-wise, the PR is fine. The best part is probably that the |
|
I finally had time to continue working on it today. I updated the description above and the PR is now officially ready for your opinion. @lenhard Personally, I'm in favor of keeping the buttons black. @lenhard With the refactoring, two fxml files were introduced: one for the whole entry editor and a second for the bibtex key field. The first one is loaded at the very start of jabref and the second every time the required fields tab is shown. Admittedly, parsing and instantiating fxml files has an overhead; but it should be negliable as long as you don't load to many fxml files at the same time (e.g. like last time where every editor field was in a separate fxml and a refresh loaded >100 of them). I didn't noticed any performance-degradation with this PR. @mlep Good points! The "change entry type" pop-up is now shown on a normal right click. |
Since this PR was now ready for review for nearly one month, I'll merge it. If you have further remarks concerning the code and the changes, I'll of course revisit the PR and implement your feedback. |
Since quite some time passed since the last issue was created concerning the entry editor, I feel like this component is getting way to stable and no longer annoys users. Thinking hard about how to reintroduce the necessary amount of bugs, I hereby propose to rework the entry editor toolbar using JavaFX.
Before:
After:
I tried to clean-up the ui as much as possible by removing a few buttons and changing the size/space.
The following buttons were removed:
Other changes:
gradle localizationUpdate
?