[WIP] Integrate journal abbreviations into JabRef #3123
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meetings are good for easy programming tasks...
This takes care of parts of #919. It takes the existing built-in journal lists and transforms them from text files into source code. We've found the abbreviation loading to be a performance problem. This should reduce this problem a little, because we replace file parsing with class loading and the reading of the lists can be optimized by the compiler. Changes are completely internal to the abbreviation code.
This doesn't check the lists for consistency, the other parts of #919. It just takes the existing lists and turn them into source code.
This doesn't need to be merged into 4.0, but can be included later.
EDIT: Turns out our built-in list has 15195. This is too large for a Java class and I am getting the error
Error:(8, 45) java: code too large
on compilation. So we need to think about this. We can leave the built-in list as a text file (no performance improvement) or distribute it into multiple source code files (seems rather brittle).gradle localizationUpdate
?