New home for snap -> buildres/snapcraft #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Is this ready for review? I guess this is not relevant for the beta-3 anyways? |
stefan-kolb
approved these changes
Aug 16, 2017
|
Build goes through (locally using https://hub.docker.com/r/koppor/snapcraft-java-de/), so this change really works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses c2fb270#commitcomment-23656145
The normal home for snapcraft files (especially,
/snap/gui/jabref.deskop) is/snap. See https://snapcraft.io/docs/build-snaps/metadata#fixed-assets. I could not find documentation, why/snap/.snapcraftwas generated.With this PR, we do not follow the snap convention, but enforce our own folder layout by placing stuff in
buildres. To make the use ofsnapcraftexplicit, I also named the foldersnapcraftinstead ofsnap.