Fix a few smaller group related things #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erences and removed a few obsolete group preferences
29 tasks
|
You increased the StringUtil method, which resulted in an architecture test error |
|
I am not angry for increasing StringUtil, I am angry for just ignoring the broken test that resulted from the increase and merging this PR into master. That effectively breaks all builds on master. At the very least, you should change the test so that it passes. I just did this as a quick-fix in d1c8569 |
|
Yes sorry didn't saw the failing test (first only the language tests were failing and I fixed them and merged directly afterwards). Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge immediately since they are only small changes...
gradle localizationUpdate?