Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few groups actions #2674

Merged
merged 3 commits into from
Mar 31, 2017
Merged

Add a few groups actions #2674

merged 3 commits into from
Mar 31, 2017

Conversation

tobiasdiez
Copy link
Member

@tobiasdiez tobiasdiez commented Mar 20, 2017

Adds:

  • "Edit group"
  • "Remove group keep subgroups"
  • "Remove subgroups"
  • Add / remove selected entries to / from group

They work in principle, but the display of the groups tree is not updated properly in some cases. I will address this in a new PR.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 20, 2017
@Siedlerchr
Copy link
Member

Siedlerchr commented Mar 25, 2017

On general okay: Not sure about the uncommented stuff. You should delete this
And check for coday

@tobiasdiez
Copy link
Member Author

tobiasdiez commented Mar 31, 2017

Thanks for the feedback. The uncommented code is a reminder for myself (and others) of things that still have to be implemented. For example, undo/redo of group actions is not possible right now.

Will merge this...

@tobiasdiez tobiasdiez merged commit 55b1dff into master Mar 31, 2017
@tobiasdiez tobiasdiez deleted the addGroupOptions branch March 31, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants