Change "Recent Files" to "Recent Databases" #2103
Conversation
mairdl
force-pushed
the
RecentDatabase
branch
from
47b90ea
to
0032567
Compare
| @@ -22,7 +22,7 @@ | |||
|
|
|||
|
|
|||
| public FileHistoryMenu(JabRefPreferences prefs, JabRefFrame frame) { | |||
| String name = Localization.menuTitle("Recent files"); | |||
| String name = Localization.menuTitle("Recent_databases"); | |||
There was a problem hiding this comment.
Underscore is not needed in when using translations in code.
| @@ -56,7 +56,7 @@ Paste=&Paste | |||
| Preferences=&Preferences | |||
| Previous_tab=&Previous_tab | |||
| Quit=&Quit | |||
| Recent_files=&Recent_files | |||
| Recent_databases=Recent_databases | |||
There was a problem hiding this comment.
Please add the & sign in front of the 'R' of the translated string as before. In the menu properties this indicates which letter should be used as mnemonic for the underlying action.
There was a problem hiding this comment.
I see i will correct it
| @@ -56,7 +56,7 @@ Paste=&Einfügen | |||
| Preferences=&Einstellungen | |||
| Previous_tab=&Vorheriger_Tab | |||
| Quit=&Beenden | |||
| Recent_files=&Zuletzt_geöffnete_Dateien | |||
| Recent_databases= | |||
There was a problem hiding this comment.
Please add a German translation as I think this was the whole idea of the linked pr.
| @@ -56,7 +56,7 @@ Paste=&Pegar | |||
| Preferences=&Preferencias | |||
| Previous_tab=&Pestaña_anterior | |||
| Quit=&Salir | |||
| Recent_files=Bases_de_datos_&recientes | |||
| Recent_databases= | |||
There was a problem hiding this comment.
Only the key should be changed, not the values. We have no clue, whether all the other translations use a translation of "File" or "Database". Even though, some language use "File", I lean towards a more complete translation instead of having an incomplete one. - In the concrete case here "Bases de datos" seems to be the translation of "databases" and has for sure to be kept.
So, please, just change the key and do not remove the translation.
There was a problem hiding this comment.
I think if we leave the old translations like they are now, no one feels like imediatly updating the translation. By removing them completly the need to change ist bigger.
There was a problem hiding this comment.
@boceckts what do you think?
|
As @koppor pointed out in some languages this is already translated as "recent databases". So it is probably better to leave the already translated strings. Also you don't know if in different languages the other database related strings are always translated as "database" and not file as it was the case in the german translation. On Oct 2, 2016, 16:17, at 16:17, Daniel Mair notifications@github.com wrote:
|
|
Ok, in that case i will "translate" them. 💃 |
boceckts
added
the
status: ready-for-review
boceckts
changed the title
|
LGTM 👍 |
* Change recent files to recent databases * localizationUpdate * describe changes in CHANGELOG.md * localization update * Fix internal qs comments * Add old translation to the new key
This is a followup of #1988.
In the sense of the PR mentioned above, I changed "Recent files" to "Recent databases". Since it only displays recently opened databases.
This is the file menu after the changes:
As you can see it fits in with the rest of the menu. One could say change the file menu to the database menu, but I think keeping the file menu named as it is, is better because it stays consistent with other programms.
Furthermore the issue #2095 seems to be related.
gradle localizationUpdate?