-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
citationkey pattern always overwrites key, regardless of chosen key in entry-merge dialogue #8644
Comments
Workaround: Have |
Refs #6190 |
The more I think about it...: JabRef might work as expected. JabRef does exactly what the preference says: JabRef overwrites the key This issue here demonstrates that it could be sensible to add some kind of tool-tip or decoration/validation (controlsfx) as feedback mechanism to the user in the duplicate merger dialogue. Example for tool-tip message: |
Can still reproduce with JabRef 5.8 development version commit bd77d73, which is after the big rework of the duplicate manager. |
Another solution:
In other words: If the preference is enabled, then regardless of choosing Old key, From Import or Merged Entry the output will always the key that results from the pattern set in the preferences and this key may not necessarily be the one showing in "Merged Entry", therefore show the key set from the pattern in the preferences in the merged entry cell instead of merged key (and do not allow users to edit it). It is just a matter of displaying it, so that users may not have wrong expectations. Edit: But i think just a simple tooltip as proposed in #8644 (comment) might be the easier and more informative solution. |
JabRef version
Latest development branch build (please note build date below)
Operating system
Windows
Details on version and operating system
JabRef 5.6--2022-04-04--dbf921e Windows 10 10.0 amd64 Java 17.0.2 JavaFX 18+12
Checked with the latest development build
Steps to reproduce the behaviour
Follow up to #8641
How to reproduce:
options>preferenes>import and export>generate a new key for imported entries (overwriting their default)
enabled.Keep merged entry only
,Import and remove old entry
orImport and keep old entry
What happens:
One is not able to choose the right side key.
Keep merged entry only
: key of new entry will have citationkey pattern applied (bad).Import and keep old entry
: key of new entry will have citationkey pattern applied (bad). Ana
is added to prevent duplicate (Good).Import and remove old entry
: key of new entry will have citationkey pattern applied (bad).Appendix
No response
The text was updated successfully, but these errors were encountered: