Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict selection of multiple radio buttons that belong to the same group to just one #4409

Closed
shahamish150294 opened this issue Oct 26, 2018 · 5 comments
Closed

Restrict selection of multiple radio buttons that belong to the same group to just one #4409

shahamish150294 opened this issue Oct 26, 2018 · 5 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. preferences

Comments

@shahamish150294
Copy link
Contributor

JabRef version on Windows 10/Java 8.

In Preferences, there are instances at which we need to select an option through radio buttons. Eg: Check screenshot attached. There are many instances in the Preferences where I am able to select multiple radio buttons for each group. Either we need to use checkboxes if multi-select is to be allowed or we should group the radio buttons under a toggle group as done here https://github.com/JabRef/jabref/pull/4408/files#diff-e0f0e1ade7c4cee8c43b0bb2254c21ebR123

I debugged an verified this issue. If multiple options are selected then always the first option (out of all the other selected options) in the if-else condition gets set as the preference.
Steps to reproduce the behavior:

  1. Start the app
  2. Go to Options > Preferences > Entry Editor
  3. Enable autocomplete options
  4. Under the "Name format used for auto completion" option, you should be able to select all the options

image
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. preferences labels Oct 26, 2018
@Siedlerchr Siedlerchr self-assigned this Oct 26, 2018
@Siedlerchr
Copy link
Member

Toggle Group seems like the best solution to me. Do you want to fix this?

@paulKra
Copy link
Contributor

paulKra commented Oct 26, 2018

Hi, we are two students who found your project through the awesome beginners page and wanted to try on a issue before. If @shahamish150294 does not want to fix it, we would like to try, if he is okay with it.

@shahamish150294
Copy link
Contributor Author

@paulKra Sure, go ahead! I haven't started this yet. Let me know if you have any questions.

@Siedlerchr Siedlerchr removed their assignment Oct 27, 2018
@paulKra
Copy link
Contributor

paulKra commented Oct 27, 2018 •
edited
Loading

@shahamish150294 Thanks.
I tried to find all instances of this bug. So far i got
Entry table > Format of author and editor names,
Entry edirtor > Treatment of first names and
Import > Default import style for drag and drop of PDFs
additional to your example. Did i miss some or add one mistakenly?
Edit: On a second look, seems like i forgot some:
File > Do not wrap the following fields when saving
File > Autolink
Entry Table Columns >URL or DOI first
Groups > View Display entries
Edit2: Even More, I simply added every Radiobutton not in a Togglegroup to one now.

paulKra added a commit to paulKra/jabref that referenced this issue Oct 29, 2018
@paulKra
Fix radiobuttons in preference menu (JabRef#4409)
ad20e4e 
Previously multiple radiobuttons in preference menu belonging to the same group were selectable simultaneously
@Tobnac Tobnac mentioned this issue Oct 29, 2018
Merged
paulKra added a commit to paulKra/jabref that referenced this issue Oct 29, 2018
@paulKra
Fix radiobuttons in preference menu (JabRef#4409)
1a4c4d2 
Previously multiple radiobuttons in preference menu belonging to the same group were selectable simultaneously
paulKra added a commit to paulKra/jabref that referenced this issue Oct 29, 2018
@paulKra
Fix radiobuttons in preference menu (JabRef#4409)
68469b2 
Previously multiple radiobuttons in preference menu belonging to the same group were selectable simultaneously
@tobiasdiez
Copy link
Member

Thanks to @paulKra this is now fixed.

Siedlerchr added a commit that referenced this issue Nov 1, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into docbookfive
231b1eb 
* upstream/master:
  Add submodule pull to circle ci and fix theme loading css (#4443)
  fix groups drag and drop (#4439)
  Convert merge entries dialog to JavaFX (#4410)
  Fix ArrayIndexOutOfBoundsException on second pdf import (#4426)
  Fix radiobuttons in preference menu (#4409)
  Add citation styles as git submodule (#4431)
  Fix highlight color of selected text and progress bar (#4420)
  Fix two new issues
  Fix Violations of Always Use Braces (#4400)
  Delete PreferencesService.java.orig
  Add JabRef icon to installer and change watermark to JabRef (#4421)
  Checkstyle: force braces around code blocks
Siedlerchr added a commit that referenced this issue Nov 3, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
f9765fc 
* upstream/master:
  New Crowdin translations (#4454)
  Fix error in l10n file: Toogle -> Toggle (#4453)
  Remove depandabot
  Bump junit-pioneer from 0.2.2 to 0.3.0 (#4451)
  Add Depandabot badge
  Emphasize that users should try out the newest version before reporting a bug
  Add a preference to add files in entry editor (#4408)
  Add submodule pull to circle ci and fix theme loading css (#4443)
  fix groups drag and drop (#4439)
  Convert merge entries dialog to JavaFX (#4410)
  Fix ArrayIndexOutOfBoundsException on second pdf import (#4426)
  Fix radiobuttons in preference menu (#4409)
  Add citation styles as git submodule (#4431)
  Fix highlight color of selected text and progress bar (#4420)
  Fix two new issues
  Fix Violations of Always Use Braces (#4400)
  Delete PreferencesService.java.orig
  Add JabRef icon to installer and change watermark to JabRef (#4421)
  Checkstyle: force braces around code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. preferences
Projects
Bugs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Siedlerchr @tobiasdiez @shahamish150294 @paulKra