Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resorting of groups using drag & drop #2785

Closed
tobiasdiez opened this issue Apr 23, 2017 · 2 comments
Closed

Allow resorting of groups using drag & drop #2785

tobiasdiez opened this issue Apr 23, 2017 · 2 comments

Comments

@tobiasdiez
Copy link
Member

Resort groups by drag and drop as raised in #2656 (comment) and further discussed in #2599.

@AEgit
Copy link

AEgit commented Apr 23, 2017

To add upon this: When a group is assigned as subgroup to another group, the focus on this group is lost. Instead the group that was found below the initial group is selected.

  1. Select a group
  2. Drag'n'drop selected group onto another group, to reassign it as respective subgroup
  3. The focus on this subgroup is lost in the groups panel - Instead the group that was initially found below the reassigned group is selected

@AEgit
Copy link

AEgit commented May 25, 2017

I can confirm that the resorting of groups using drag'n'drop works in:
JabRef 4.0.0-dev--snapshot--2017-05-25--master--4c87dde9c
Windows 10 10.0 amd64
Java 1.8.0_131

The issue I reported above, however, persists. Every time you assign a group to a new subgroup, the focus on your selected group is lost after the assignment. I will open a new ticket for this: #2868

Siedlerchr added a commit that referenced this issue May 27, 2017
* upstream/master: (23 commits)
  Implement #2785: resort groups using drag & drop (#2864)
  Add Library of Congress as ID-fetcher (#2865)
  Fix export and import of MS office day/year/month acessed fields (#2862)
  Adsurl to url (#2861)
  Update LICENSE.md
  Update
  Update LICENSE.md
  Update license file so that github recognize it properly
  Improve Issue Template Using a Collapsible Log Area
  Fix #2852: Improve performance of group filtering.
  Rename GroupSelector to GroupSidePane
  Fix #2843: Show information correctly in entry editor
  Remove old entry editor code related to focus selection
  Implement feedback
  Menu Greek Translation (#2836)
  Relaxed the regex to also match negative timezone formats when parsing pdf annotation dates (#2841)
  Update localization
  Remove unnecessary group code (and move remaining settings to preferences)
  Add Local Maven repo as first lookup resource, to avoid having duplicate libs in gradle and maven
  Implement #2786: Allow selection of multiple groups
  ...
Siedlerchr added a commit that referenced this issue Jun 3, 2017
* upstream/master: (38 commits)
  Add link to "feature branch workflow"
  Support Annotations Created by Foxit (#2878)
  Fixes jacoco by excluding the fetcher tests from analysis (#2877)
  Fix entry editor (#2875)
  update bcprov-jdk15on from 1.56 -> 1.57
  update assertj-swing-junit from 3.5.0 -> 3.6.0
  update mockito-core from 2.7.22 -> 2.8.9
  update jfx from 0.11.0 -> 0.11.1
  update google guava from 21.0 -> 22.0
  Fix Divide by zero exception if rows is zero in Entry Editor Tab (#2873)
  Implement #2785: resort groups using drag & drop (#2864)
  Add Library of Congress as ID-fetcher (#2865)
  Fix export and import of MS office day/year/month acessed fields (#2862)
  Adsurl to url (#2861)
  Update LICENSE.md
  Update
  Update LICENSE.md
  Update license file so that github recognize it properly
  Improve Issue Template Using a Collapsible Log Area
  Fix #2852: Improve performance of group filtering.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants