New validation rules and formatting in error messages #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit modifies validation rules in various schema examples (full.json, full.php, full.yml, full_clean.yml), such as changing the contains rule from "Hello" to "World". In addition, the formatting for the quartiles computation in the ComboQuartiles PHP file has been refined. Additional IPs and URL checks have been included as validation rules and existing rules have been re-ordered for better readability.
Pull Request Test Coverage Report for Build 8454871491Details
💛 - Coveralls |
Refactored code to improve readability and maintainability by standardizing how lists are formatted in error messages and validation rules. This includes updates to the schema examples, and changes in the implementation of the Utils::printList method. The changes are also reflected in various validation rules and tests.
SmetDenis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit modifies validation rules in various schema examples (full.json, full.php, full.yml, full_clean.yml), such as changing the contains rule from "Hello" to "World". In addition, the formatting for the quartiles computation in the ComboQuartiles PHP file has been refined. Additional IPs and URL checks have been included as validation rules and existing rules have been re-ordered for better readability.