Suggestion: don't rayon-parallelise when on wasm32 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wehlutyk
added a commit
to wehlutyk/infuse
that referenced
this pull request
Oct 16, 2019
Can be removed if J-F-Liu/lopdf#83 gets merged.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, the story for spawning threads on wasm is not entirely settled (see the conversation in rayon-rs/rayon#636), meaning that using
par_iter()andpar_chunks()panics in the browser.One solution is for lopdf consumers to follow the parallel raytracing example from wasm-bindgen, but at the time of writing that makes building a binary pretty non-standard.
So this PR proposes to simply disable rayon parallelisation when building for wasm, until the story for wasm threads reaches a more stable state. Let me know what you think!