Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly instanciate recursion index #23

Merged
merged 1 commit into from
May 3, 2021
Merged

Conversation

damienmg
Copy link
Contributor

@damienmg damienmg commented May 2, 2021

Caller of the flatternRecursion method does not set necessarily the index value and OpenSCAD complain that this result in adding number to undefined.

Fixes #22

Caller of the flatternRecursion method does not set necessarily the index value and OpenSCAD complain that this result in adding number to undefined.
@Irev-Dev
Copy link
Owner

Irev-Dev commented May 2, 2021

Appreciate the PR @damienmg, I'll have a proper look very soon.

Copy link

@fex42 fex42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and fixes the problem. Thank you!
(I guess I can not approve the change but looks good not only for the example but my own designs)

@Irev-Dev Irev-Dev self-assigned this May 3, 2021
Copy link
Owner

@Irev-Dev Irev-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @damienmg.

@Irev-Dev Irev-Dev merged commit f9928e3 into Irev-Dev:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants