Add a compiler flag for the evaluateBuiltins pass #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ana-pantilie
approved these changes
Sep 6, 2024
| @@ -171,10 +171,12 @@ pluginOptions = | |||
| , Implication (== True) posPreserveLogging True | |||
| , Implication (== True) posCaseOfCaseConservative True | |||
| , Implication (== True) posInlineConstants False | |||
| , Implication (== True) posDoSimplifierEvaluateBuiltins False | |||
There was a problem hiding this comment.
It gets turned off here because it may increase program size?
There was a problem hiding this comment.
Because it may change semantics: #6167
effectfully
reviewed
Sep 9, 2024
| , Implication (== False) posRelaxedFloatin True | ||
| , Implication (== False) posPreserveLogging False | ||
| , Implication (== False) posCaseOfCaseConservative False | ||
| , Implication (== False) posInlineConstants True | ||
| , Implication (== False) posDoSimplifierEvaluateBuiltins True |
There was a problem hiding this comment.
My OCD would prefer id over (== True) and not over (== False), but I guess it's currently more readable.
| @@ -230,6 +232,11 @@ pluginOptions = | |||
| , let k = "simplifier-beta" | |||
| desc = "Run a simplification pass that performs beta transformations" | |||
| in (k, PluginOption typeRep (setTrue k) posDoSimplifierBeta desc []) | |||
| , let k = "simplifier-evaluate-builtins" | |||
| desc = | |||
| "Run a simplification pass that evaluates fully saturated builtin applications. \ | |||
There was a problem hiding this comment.
Please add some comments! To the pass itself and somewhere here, so that the user knows they are enabling a semantics-changing pass. At least the link to the issue.
kozross
pushed a commit
to mlabs-haskell/plutus
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is currently missing,
_posDoSimplifierEvaluateBuiltinsis always true and cannot be turned off.