Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misplaced size tests golden files. #5552

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Fix misplaced size tests golden files. #5552

merged 3 commits into from
Sep 21, 2023

Conversation

thealmarty
Copy link
Contributor

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@thealmarty thealmarty force-pushed the thealmarty/fix-misplaced-golden-files branch from 43cba29 to 1ff4917 Compare September 20, 2023 16:10
@thealmarty thealmarty force-pushed the thealmarty/fix-misplaced-golden-files branch from 1ff4917 to 05f481b Compare September 20, 2023 16:12
@thealmarty thealmarty marked this pull request as ready for review September 20, 2023 19:05
@thealmarty
Copy link
Contributor Author

If @michaelpj you could re-trigger the CI please. It seems it's having some transient errors.

@michaelpj
Copy link
Contributor

It did in fact re-evaluate and succeed, so I'll just merge this.

@michaelpj michaelpj merged commit b6e8c56 into master Sep 21, 2023
8 of 95 checks passed
@michaelpj michaelpj deleted the thealmarty/fix-misplaced-golden-files branch September 21, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj Awaiting requested review from michaelpj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thealmarty @michaelpj