Fix testOrd
#5503
Merged
Fix testOrd
#5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
approved these changes
Aug 30, 2023
plutus-tx-plugin/test/StdLib/Spec.hs
Outdated
| -- Ratio must have non-zero denominator or else an ArithException will be thrown. | ||
| gen' = | ||
| Gen.choice | ||
| [Gen.integral (Range.linear (-10000) (-1)), Gen.integral (Range.linear 1 100000)] |
There was a problem hiding this comment.
filter would perhaps be a bit more readable, but this is fine too.
There was a problem hiding this comment.
Thanks, filter is much better.
michaelpj
reviewed
Aug 31, 2023
| @@ -4,6 +4,7 @@ | |||
| {-# LANGUAGE TemplateHaskell #-} | |||
| {-# OPTIONS_GHC -fno-specialise #-} | |||
| {-# OPTIONS_GHC -fno-warn-orphans #-} | |||
| {-# OPTIONS_GHC -ddump-splices #-} | |||
There was a problem hiding this comment.
this shouldn't have been committed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fails if ratio denominator is 0: https://github.com/input-output-hk/plutus/runs/16359392302