[Test] Dump types for 'stdlib' and 'examples' #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjaskelioff
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
This file is called unsafeCoerce, because it has the type of Haskell's unsafeCoerce. What about its semantics?
Does it behave like unsafeCoerce as well? Or is it equivalent to
diverge : all b. b
diverge = ...
unsafeCoerce : all a b. a -> b
unsafeCoerce a = diverge
There was a problem hiding this comment.
I saw the comment on the other PR. It is indeed fix id, so while the typing corresponds to unsafeCoerce, it doesn't behave like it, so it's misleading to call it like that. It's not unsafe to execute it. Perhaps divergeCoerce would be more appropriate?
There was a problem hiding this comment.
Great point, I'll rename it. Thanks!
michaelpj
deleted the
effectfully/test/dump-types-for-stdlib-and-examples
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only test that the type of each builtin from the default set of builtins is well-kinded and stays the same for the latest version. We should explicitly check all versions instead.
We also do not dump the types of definitions from stdlib and examples, we only check that those definitions are well-typed. We should dump the types, so that we can be sure those won’t suddenly change without us noticing.
Resolves PLT-6979.