Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Builtins] Add an inlinable version of 'GEq' #4462

Closed
wants to merge 4 commits into from
Closed

[Builtins] Add an inlinable version of 'GEq' #4462

wants to merge 4 commits into from

Conversation

effectfully
Copy link
Contributor

Don't look here yet.

@effectfully effectfully force-pushed the effectfully/builtins/inlinable-GEq branch from d40f4bc to 8c0fbe1 Compare March 10, 2022 10:19
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'edcf0e886' (base) and '8c0fbe11d' (PR)

Script edcf0e8 8c0fbe1 Change
auction_1-1 266.5 μs 264.2 μs -0.9%
auction_1-2 922.4 μs 909.9 μs -1.4%
auction_1-3 915.2 μs 906.8 μs -0.9%
auction_1-4 347.8 μs 344.3 μs -1.0%
auction_2-1 267.7 μs 264.5 μs -1.2%
auction_2-2 924.7 μs 910.5 μs -1.5%
auction_2-3 1.174 ms 1.156 ms -1.5%
auction_2-4 918.3 μs 905.1 μs -1.4%
auction_2-5 346.9 μs 344.2 μs -0.8%
crowdfunding-success-1 313.7 μs 310.0 μs -1.2%
crowdfunding-success-2 313.5 μs 309.9 μs -1.1%
crowdfunding-success-3 313.8 μs 309.2 μs -1.5%
currency-1 354.3 μs 350.3 μs -1.1%
escrow-redeem_1-1 519.3 μs 514.1 μs -1.0%
escrow-redeem_1-2 518.0 μs 513.0 μs -1.0%
escrow-redeem_2-1 605.4 μs 598.4 μs -1.2%
escrow-redeem_2-2 604.8 μs 597.0 μs -1.3%
escrow-redeem_2-3 605.9 μs 597.7 μs -1.4%
escrow-refund-1 234.5 μs 230.4 μs -1.7%
future-increase-margin-1 355.3 μs 353.2 μs -0.6%
future-increase-margin-2 795.5 μs 787.1 μs -1.1%
future-increase-margin-3 794.3 μs 786.3 μs -1.0%
future-increase-margin-4 733.0 μs 721.7 μs -1.5%
future-increase-margin-5 1.124 ms 1.114 ms -0.9%
future-pay-out-1 355.0 μs 351.4 μs -1.0%
future-pay-out-2 793.2 μs 783.4 μs -1.2%
future-pay-out-3 794.9 μs 784.6 μs -1.3%
future-pay-out-4 1.129 ms 1.110 ms -1.7%
future-settle-early-1 356.8 μs 350.7 μs -1.7%
future-settle-early-2 797.3 μs 782.7 μs -1.8%
future-settle-early-3 796.4 μs 780.6 μs -2.0%
future-settle-early-4 872.7 μs 855.4 μs -2.0%
game-sm-success_1-1 584.5 μs 575.2 μs -1.6%
game-sm-success_1-2 295.8 μs 290.3 μs -1.9%
game-sm-success_1-3 926.2 μs 908.2 μs -1.9%
game-sm-success_1-4 344.2 μs 339.5 μs -1.4%
game-sm-success_2-1 582.8 μs 574.0 μs -1.5%
game-sm-success_2-2 294.9 μs 290.6 μs -1.5%
game-sm-success_2-3 920.8 μs 909.1 μs -1.3%
game-sm-success_2-4 343.9 μs 341.6 μs -0.7%
game-sm-success_2-5 925.5 μs 911.5 μs -1.5%
game-sm-success_2-6 345.5 μs 341.7 μs -1.1%
multisig-sm-1 589.9 μs 581.2 μs -1.5%
multisig-sm-2 577.2 μs 571.2 μs -1.0%
multisig-sm-3 583.6 μs 577.2 μs -1.1%
multisig-sm-4 589.4 μs 584.2 μs -0.9%
multisig-sm-5 813.6 μs 801.5 μs -1.5%
multisig-sm-6 589.1 μs 580.8 μs -1.4%
multisig-sm-7 576.4 μs 569.8 μs -1.1%
multisig-sm-8 583.4 μs 574.9 μs -1.5%
multisig-sm-9 590.1 μs 580.9 μs -1.6%
multisig-sm-10 814.4 μs 804.2 μs -1.3%
ping-pong-1 490.0 μs 479.3 μs -2.2%
ping-pong-2 489.0 μs 479.9 μs -1.9%
ping-pong_2-1 296.6 μs 292.6 μs -1.3%
prism-1 245.0 μs 243.6 μs -0.6%
prism-2 629.3 μs 621.3 μs -1.3%
prism-3 537.0 μs 531.8 μs -1.0%
pubkey-1 208.5 μs 206.5 μs -1.0%
stablecoin_1-1 1.284 ms 1.269 ms -1.2%
stablecoin_1-2 287.7 μs 282.8 μs -1.7%
stablecoin_1-3 1.475 ms 1.461 ms -0.9%
stablecoin_1-4 306.9 μs 303.1 μs -1.2%
stablecoin_1-5 1.878 ms 1.861 ms -0.9%
stablecoin_1-6 379.6 μs 374.8 μs -1.3%
stablecoin_2-1 1.281 ms 1.274 ms -0.5%
stablecoin_2-2 287.1 μs 283.8 μs -1.1%
stablecoin_2-3 1.475 ms 1.461 ms -0.9%
stablecoin_2-4 306.6 μs 301.3 μs -1.7%
token-account-1 274.1 μs 270.5 μs -1.3%
token-account-2 481.1 μs 472.7 μs -1.7%
uniswap-1 586.0 μs 571.4 μs -2.5%
uniswap-2 326.4 μs 322.0 μs -1.3%
uniswap-3 2.415 ms 2.378 ms -1.5%
uniswap-4 505.0 μs 502.5 μs -0.5%
uniswap-5 1.680 ms 1.650 ms -1.8%
uniswap-6 482.0 μs 480.1 μs -0.4%
vesting-1 503.5 μs 498.6 μs -1.0%

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'edcf0e886' (base) and 'b06b651dc' (PR)

Script edcf0e8 b06b651 Change
auction_1-1 267.1 μs 259.4 μs -2.9%
auction_1-2 925.1 μs 911.0 μs -1.5%
auction_1-3 921.1 μs 904.6 μs -1.8%
auction_1-4 348.6 μs 338.3 μs -3.0%
auction_2-1 268.9 μs 260.0 μs -3.3%
auction_2-2 923.1 μs 913.0 μs -1.1%
auction_2-3 1.173 ms 1.158 ms -1.3%
auction_2-4 915.4 μs 906.3 μs -1.0%
auction_2-5 347.3 μs 338.4 μs -2.6%
crowdfunding-success-1 314.1 μs 306.2 μs -2.5%
crowdfunding-success-2 313.4 μs 306.7 μs -2.1%
crowdfunding-success-3 313.3 μs 305.9 μs -2.4%
currency-1 354.5 μs 351.0 μs -1.0%
escrow-redeem_1-1 519.6 μs 509.5 μs -1.9%
escrow-redeem_1-2 519.2 μs 509.2 μs -1.9%
escrow-redeem_2-1 606.8 μs 597.0 μs -1.6%
escrow-redeem_2-2 606.8 μs 600.2 μs -1.1%
escrow-redeem_2-3 607.6 μs 598.5 μs -1.5%
escrow-refund-1 234.1 μs 228.0 μs -2.6%
future-increase-margin-1 355.6 μs 352.1 μs -1.0%
future-increase-margin-2 793.4 μs 784.2 μs -1.2%
future-increase-margin-3 794.6 μs 784.8 μs -1.2%
future-increase-margin-4 736.3 μs 723.6 μs -1.7%
future-increase-margin-5 1.130 ms 1.111 ms -1.7%
future-pay-out-1 357.3 μs 351.3 μs -1.7%
future-pay-out-2 797.6 μs 783.5 μs -1.8%
future-pay-out-3 796.5 μs 781.4 μs -1.9%
future-pay-out-4 1.124 ms 1.108 ms -1.4%
future-settle-early-1 355.9 μs 350.7 μs -1.5%
future-settle-early-2 794.8 μs 786.0 μs -1.1%
future-settle-early-3 792.4 μs 785.7 μs -0.8%
future-settle-early-4 868.2 μs 858.8 μs -1.1%
game-sm-success_1-1 581.3 μs 572.8 μs -1.5%
game-sm-success_1-2 294.3 μs 289.3 μs -1.7%
game-sm-success_1-3 918.5 μs 908.3 μs -1.1%
game-sm-success_1-4 345.0 μs 337.1 μs -2.3%
game-sm-success_2-1 582.4 μs 574.0 μs -1.4%
game-sm-success_2-2 295.2 μs 290.7 μs -1.5%
game-sm-success_2-3 922.5 μs 910.5 μs -1.3%
game-sm-success_2-4 345.1 μs 337.7 μs -2.1%
game-sm-success_2-5 921.2 μs 909.5 μs -1.3%
game-sm-success_2-6 344.9 μs 337.6 μs -2.1%
multisig-sm-1 586.9 μs 583.1 μs -0.6%
multisig-sm-2 578.1 μs 571.9 μs -1.1%
multisig-sm-3 586.1 μs 579.0 μs -1.2%
multisig-sm-4 593.3 μs 584.9 μs -1.4%
multisig-sm-5 815.4 μs 808.6 μs -0.8%
multisig-sm-6 589.9 μs 583.2 μs -1.1%
multisig-sm-7 577.0 μs 571.3 μs -1.0%
multisig-sm-8 584.1 μs 577.8 μs -1.1%
multisig-sm-9 589.2 μs 583.2 μs -1.0%
multisig-sm-10 810.1 μs 804.6 μs -0.7%
ping-pong-1 485.2 μs 479.9 μs -1.1%
ping-pong-2 487.4 μs 481.4 μs -1.2%
ping-pong_2-1 295.8 μs 291.1 μs -1.6%
prism-1 245.1 μs 241.5 μs -1.5%
prism-2 627.2 μs 621.8 μs -0.9%
prism-3 535.3 μs 529.7 μs -1.0%
pubkey-1 207.9 μs 203.9 μs -1.9%
stablecoin_1-1 1.281 ms 1.267 ms -1.1%
stablecoin_1-2 288.8 μs 282.3 μs -2.3%
stablecoin_1-3 1.478 ms 1.460 ms -1.2%
stablecoin_1-4 307.0 μs 300.7 μs -2.1%
stablecoin_1-5 1.879 ms 1.852 ms -1.4%
stablecoin_1-6 381.4 μs 372.9 μs -2.2%
stablecoin_2-1 1.288 ms 1.267 ms -1.6%
stablecoin_2-2 288.9 μs 281.9 μs -2.4%
stablecoin_2-3 1.473 ms 1.450 ms -1.6%
stablecoin_2-4 305.9 μs 298.5 μs -2.4%
token-account-1 272.9 μs 268.7 μs -1.5%
token-account-2 478.6 μs 470.7 μs -1.7%
uniswap-1 584.5 μs 578.0 μs -1.1%
uniswap-2 325.4 μs 321.3 μs -1.3%
uniswap-3 2.414 ms 2.376 ms -1.6%
uniswap-4 506.0 μs 495.0 μs -2.2%
uniswap-5 1.686 ms 1.649 ms -2.2%
uniswap-6 482.4 μs 474.7 μs -1.6%
vesting-1 503.0 μs 498.5 μs -0.9%

@effectfully effectfully force-pushed the effectfully/builtins/inlinable-GEq branch from b06b651 to 5a3e025 Compare March 21, 2022 11:09
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'dc9275462' (base) and '5a3e025a2' (PR)

Script dc92754 5a3e025 Change
auction_1-1 242.0 μs 238.3 μs -1.5%
auction_1-2 880.8 μs 876.4 μs -0.5%
auction_1-3 876.2 μs 865.3 μs -1.2%
auction_1-4 314.4 μs 310.5 μs -1.2%
auction_2-1 242.8 μs 240.3 μs -1.0%
auction_2-2 889.1 μs 876.5 μs -1.4%
auction_2-3 1.125 ms 1.111 ms -1.2%
auction_2-4 877.0 μs 865.9 μs -1.3%
auction_2-5 313.5 μs 309.9 μs -1.1%
crowdfunding-success-1 284.6 μs 281.3 μs -1.2%
crowdfunding-success-2 284.5 μs 280.9 μs -1.3%
crowdfunding-success-3 284.1 μs 280.9 μs -1.1%
currency-1 334.8 μs 330.8 μs -1.2%
escrow-redeem_1-1 486.8 μs 479.1 μs -1.6%
escrow-redeem_1-2 487.1 μs 479.5 μs -1.6%
escrow-redeem_2-1 569.9 μs 563.2 μs -1.2%
escrow-redeem_2-2 568.9 μs 563.1 μs -1.0%
escrow-redeem_2-3 571.6 μs 563.0 μs -1.5%
escrow-refund-1 215.4 μs 209.4 μs -2.8%
future-increase-margin-1 337.3 μs 331.5 μs -1.7%
future-increase-margin-2 752.5 μs 742.2 μs -1.4%
future-increase-margin-3 751.2 μs 741.5 μs -1.3%
future-increase-margin-4 696.6 μs 687.8 μs -1.3%
future-increase-margin-5 1.075 ms 1.066 ms -0.8%
future-pay-out-1 336.0 μs 330.6 μs -1.6%
future-pay-out-2 747.5 μs 740.9 μs -0.9%
future-pay-out-3 748.1 μs 741.2 μs -0.9%
future-pay-out-4 1.073 ms 1.066 ms -0.7%
future-settle-early-1 336.3 μs 332.9 μs -1.0%
future-settle-early-2 750.1 μs 745.7 μs -0.6%
future-settle-early-3 749.6 μs 745.5 μs -0.5%
future-settle-early-4 826.9 μs 821.9 μs -0.6%
game-sm-success_1-1 547.6 μs 543.7 μs -0.7%
game-sm-success_1-2 266.2 μs 263.8 μs -0.9%
game-sm-success_1-3 875.8 μs 867.5 μs -0.9%
game-sm-success_1-4 312.5 μs 308.4 μs -1.3%
game-sm-success_2-1 550.4 μs 542.4 μs -1.5%
game-sm-success_2-2 267.8 μs 262.9 μs -1.8%
game-sm-success_2-3 878.5 μs 864.2 μs -1.6%
game-sm-success_2-4 312.0 μs 307.4 μs -1.5%
game-sm-success_2-5 878.3 μs 862.8 μs -1.8%
game-sm-success_2-6 311.6 μs 306.9 μs -1.5%
multisig-sm-1 559.1 μs 548.8 μs -1.8%
multisig-sm-2 545.9 μs 537.9 μs -1.5%
multisig-sm-3 553.5 μs 545.5 μs -1.4%
multisig-sm-4 558.8 μs 551.8 μs -1.3%
multisig-sm-5 775.9 μs 767.8 μs -1.0%
multisig-sm-6 557.9 μs 552.2 μs -1.0%
multisig-sm-7 548.0 μs 539.0 μs -1.6%
multisig-sm-8 555.0 μs 543.1 μs -2.1%
multisig-sm-9 559.8 μs 553.4 μs -1.1%
multisig-sm-10 774.7 μs 768.3 μs -0.8%
ping-pong-1 461.4 μs 456.0 μs -1.2%
ping-pong-2 459.5 μs 456.5 μs -0.7%
ping-pong_2-1 274.0 μs 271.8 μs -0.8%
prism-1 222.6 μs 219.7 μs -1.3%
prism-2 594.9 μs 589.7 μs -0.9%
prism-3 503.9 μs 497.9 μs -1.2%
pubkey-1 189.7 μs 185.9 μs -2.0%
stablecoin_1-1 1.223 ms 1.200 ms -1.9%
stablecoin_1-2 260.6 μs 257.0 μs -1.4%
stablecoin_1-3 1.395 ms 1.372 ms -1.6%
stablecoin_1-4 277.0 μs 273.7 μs -1.2%
stablecoin_1-5 1.750 ms 1.732 ms -1.0%
stablecoin_1-6 344.2 μs 340.3 μs -1.1%
stablecoin_2-1 1.218 ms 1.201 ms -1.4%
stablecoin_2-2 260.2 μs 256.8 μs -1.3%
stablecoin_2-3 1.387 ms 1.367 ms -1.4%
stablecoin_2-4 276.3 μs 273.4 μs -1.0%
token-account-1 252.7 μs 250.7 μs -0.8%
token-account-2 451.7 μs 444.4 μs -1.6%
uniswap-1 553.8 μs 551.7 μs -0.4%
uniswap-2 301.4 μs 297.5 μs -1.3%
uniswap-3 2.255 ms 2.238 ms -0.8%
uniswap-4 459.5 μs 454.5 μs -1.1%
uniswap-5 1.561 ms 1.542 ms -1.2%
uniswap-6 439.7 μs 433.9 μs -1.3%
vesting-1 477.9 μs 472.2 μs -1.2%

@effectfully
Copy link
Contributor Author

-1.24% on average. Not a huge speedup, but is very cheap and removes the annoyance of seeing a clear optimization opportunity in the generated Core, so I'm going to pursue it.

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'dc9275462' (base) and '6a1211d67' (PR)

Script dc92754 6a1211d Change
auction_1-1 242.1 μs 236.2 μs -2.4%
auction_1-2 888.1 μs 868.4 μs -2.2%
auction_1-3 876.4 μs 859.0 μs -2.0%
auction_1-4 313.9 μs 306.7 μs -2.3%
auction_2-1 242.3 μs 238.3 μs -1.7%
auction_2-2 883.6 μs 873.7 μs -1.1%
auction_2-3 1.122 ms 1.106 ms -1.4%
auction_2-4 873.5 μs 864.7 μs -1.0%
auction_2-5 312.6 μs 308.9 μs -1.2%
crowdfunding-success-1 283.8 μs 279.4 μs -1.6%
crowdfunding-success-2 284.1 μs 279.3 μs -1.7%
crowdfunding-success-3 284.6 μs 278.7 μs -2.1%
currency-1 335.6 μs 333.6 μs -0.6%
escrow-redeem_1-1 485.6 μs 477.6 μs -1.6%
escrow-redeem_1-2 484.8 μs 478.1 μs -1.4%
escrow-redeem_2-1 571.6 μs 561.3 μs -1.8%
escrow-redeem_2-2 573.3 μs 560.7 μs -2.2%
escrow-redeem_2-3 573.3 μs 561.7 μs -2.0%
escrow-refund-1 214.4 μs 209.1 μs -2.5%
future-increase-margin-1 335.6 μs 332.2 μs -1.0%
future-increase-margin-2 750.4 μs 737.9 μs -1.7%
future-increase-margin-3 749.5 μs 738.3 μs -1.5%
future-increase-margin-4 694.4 μs 687.9 μs -0.9%
future-increase-margin-5 1.075 ms 1.066 ms -0.8%
future-pay-out-1 336.4 μs 332.6 μs -1.1%
future-pay-out-2 750.6 μs 741.0 μs -1.3%
future-pay-out-3 750.5 μs 740.0 μs -1.4%
future-pay-out-4 1.077 ms 1.070 ms -0.6%
future-settle-early-1 335.1 μs 333.5 μs -0.5%
future-settle-early-2 748.2 μs 737.9 μs -1.4%
future-settle-early-3 747.9 μs 737.6 μs -1.4%
future-settle-early-4 828.6 μs 817.1 μs -1.4%
game-sm-success_1-1 549.0 μs 539.4 μs -1.7%
game-sm-success_1-2 267.9 μs 261.8 μs -2.3%
game-sm-success_1-3 877.9 μs 865.2 μs -1.4%
game-sm-success_1-4 311.7 μs 306.7 μs -1.6%
game-sm-success_2-1 550.2 μs 540.8 μs -1.7%
game-sm-success_2-2 267.9 μs 260.6 μs -2.7%
game-sm-success_2-3 878.4 μs 862.0 μs -1.9%
game-sm-success_2-4 312.5 μs 305.2 μs -2.3%
game-sm-success_2-5 875.5 μs 863.9 μs -1.3%
game-sm-success_2-6 311.8 μs 304.9 μs -2.2%
multisig-sm-1 559.2 μs 550.4 μs -1.6%
multisig-sm-2 545.9 μs 538.0 μs -1.4%
multisig-sm-3 552.5 μs 546.1 μs -1.2%
multisig-sm-4 558.4 μs 553.6 μs -0.9%
multisig-sm-5 775.8 μs 768.3 μs -1.0%
multisig-sm-6 559.0 μs 551.5 μs -1.3%
multisig-sm-7 547.3 μs 539.4 μs -1.4%
multisig-sm-8 553.5 μs 546.2 μs -1.3%
multisig-sm-9 559.8 μs 552.0 μs -1.4%
multisig-sm-10 773.4 μs 765.5 μs -1.0%
ping-pong-1 459.8 μs 453.1 μs -1.5%
ping-pong-2 460.9 μs 452.0 μs -1.9%
ping-pong_2-1 275.8 μs 269.7 μs -2.2%
prism-1 223.6 μs 216.7 μs -3.1%
prism-2 596.7 μs 585.5 μs -1.9%
prism-3 502.8 μs 492.5 μs -2.0%
pubkey-1 189.1 μs 184.5 μs -2.4%
stablecoin_1-1 1.221 ms 1.191 ms -2.5%
stablecoin_1-2 261.8 μs 254.6 μs -2.8%
stablecoin_1-3 1.389 ms 1.361 ms -2.0%
stablecoin_1-4 277.5 μs 270.6 μs -2.5%
stablecoin_1-5 1.752 ms 1.711 ms -2.3%
stablecoin_1-6 343.9 μs 336.5 μs -2.2%
stablecoin_2-1 1.212 ms 1.189 ms -1.9%
stablecoin_2-2 260.4 μs 254.8 μs -2.2%
stablecoin_2-3 1.391 ms 1.368 ms -1.7%
stablecoin_2-4 277.3 μs 271.8 μs -2.0%
token-account-1 254.5 μs 252.5 μs -0.8%
token-account-2 453.6 μs 445.0 μs -1.9%
uniswap-1 556.6 μs 552.5 μs -0.7%
uniswap-2 301.5 μs 298.3 μs -1.1%
uniswap-3 2.249 ms 2.192 ms -2.5%
uniswap-4 459.0 μs 447.9 μs -2.4%
uniswap-5 1.563 ms 1.530 ms -2.1%
uniswap-6 441.0 μs 428.4 μs -2.9%
vesting-1 479.3 μs 473.5 μs -1.2%

@effectfully
Copy link
Contributor Author

-1.69% on average. That's a bit better.

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'dc9275462' (base) and 'd6fdc931a' (PR)

Script dc92754 d6fdc93 Change
auction_1-1 241.4 μs 239.4 μs -0.8%
auction_1-2 884.9 μs 876.2 μs -1.0%
auction_1-3 875.2 μs 867.0 μs -0.9%
auction_1-4 312.0 μs 311.4 μs -0.2%
auction_2-1 242.0 μs 239.8 μs -0.9%
auction_2-2 881.7 μs 871.2 μs -1.2%
auction_2-3 1.118 ms 1.105 ms -1.2%
auction_2-4 873.3 μs 861.0 μs -1.4%
auction_2-5 313.0 μs 310.6 μs -0.8%
crowdfunding-success-1 284.1 μs 280.4 μs -1.3%
crowdfunding-success-2 284.3 μs 281.1 μs -1.1%
crowdfunding-success-3 284.3 μs 280.8 μs -1.2%
currency-1 335.1 μs 333.5 μs -0.5%
escrow-redeem_1-1 487.2 μs 481.0 μs -1.3%
escrow-redeem_1-2 487.7 μs 481.5 μs -1.3%
escrow-redeem_2-1 571.9 μs 564.5 μs -1.3%
escrow-redeem_2-2 572.3 μs 564.9 μs -1.3%
escrow-redeem_2-3 571.1 μs 565.4 μs -1.0%
escrow-refund-1 213.9 μs 210.9 μs -1.4%
future-increase-margin-1 336.0 μs 331.9 μs -1.2%
future-increase-margin-2 749.0 μs 745.0 μs -0.5%
future-increase-margin-3 748.2 μs 742.8 μs -0.7%
future-increase-margin-4 693.0 μs 689.8 μs -0.5%
future-increase-margin-5 1.077 ms 1.069 ms -0.7%
future-pay-out-1 335.7 μs 332.8 μs -0.9%
future-pay-out-2 748.9 μs 742.4 μs -0.9%
future-pay-out-3 748.1 μs 741.6 μs -0.9%
future-pay-out-4 1.073 ms 1.065 ms -0.7%
future-settle-early-1 336.7 μs 332.4 μs -1.3%
future-settle-early-2 750.1 μs 740.6 μs -1.3%
future-settle-early-3 749.7 μs 741.4 μs -1.1%
future-settle-early-4 830.9 μs 817.2 μs -1.6%
game-sm-success_1-1 551.9 μs 541.7 μs -1.8%
game-sm-success_1-2 268.0 μs 265.1 μs -1.1%
game-sm-success_1-3 879.9 μs 868.1 μs -1.3%
game-sm-success_1-4 313.0 μs 310.1 μs -0.9%
game-sm-success_2-1 549.7 μs 543.2 μs -1.2%
game-sm-success_2-2 266.6 μs 265.1 μs -0.6%
game-sm-success_2-3 876.0 μs 862.9 μs -1.5%
game-sm-success_2-4 311.3 μs 308.7 μs -0.8%
game-sm-success_2-5 876.6 μs 863.4 μs -1.5%
game-sm-success_2-6 311.1 μs 309.7 μs -0.5%
multisig-sm-1 557.5 μs 553.6 μs -0.7%
multisig-sm-2 549.1 μs 540.9 μs -1.5%
multisig-sm-3 553.3 μs 549.9 μs -0.6%
multisig-sm-4 559.6 μs 555.9 μs -0.7%
multisig-sm-5 776.1 μs 771.5 μs -0.6%
multisig-sm-6 557.9 μs 555.1 μs -0.5%
multisig-sm-7 545.4 μs 540.9 μs -0.8%
multisig-sm-8 552.0 μs 546.2 μs -1.1%
multisig-sm-9 558.3 μs 552.8 μs -1.0%
multisig-sm-10 775.3 μs 769.9 μs -0.7%
ping-pong-1 461.6 μs 453.9 μs -1.7%
ping-pong-2 461.0 μs 452.9 μs -1.8%
ping-pong_2-1 275.1 μs 270.2 μs -1.8%
prism-1 222.1 μs 219.1 μs -1.4%
prism-2 595.4 μs 586.9 μs -1.4%
prism-3 503.2 μs 499.8 μs -0.7%
pubkey-1 188.9 μs 186.4 μs -1.3%
stablecoin_1-1 1.216 ms 1.194 ms -1.8%
stablecoin_1-2 261.1 μs 258.6 μs -1.0%
stablecoin_1-3 1.388 ms 1.368 ms -1.4%
stablecoin_1-4 276.6 μs 275.6 μs -0.4%
stablecoin_1-5 1.749 ms 1.728 ms -1.2%
stablecoin_1-6 342.7 μs 342.0 μs -0.2%
stablecoin_2-1 1.213 ms 1.200 ms -1.1%
stablecoin_2-2 260.9 μs 258.9 μs -0.8%
stablecoin_2-3 1.391 ms 1.372 ms -1.4%
stablecoin_2-4 276.6 μs 275.6 μs -0.4%
token-account-1 253.8 μs 251.5 μs -0.9%
token-account-2 452.1 μs 444.6 μs -1.7%
uniswap-1 555.4 μs 550.3 μs -0.9%
uniswap-2 300.7 μs 299.4 μs -0.4%
uniswap-3 2.255 ms 2.204 ms -2.3%
uniswap-4 461.1 μs 456.7 μs -1.0%
uniswap-5 1.567 ms 1.540 ms -1.7%
uniswap-6 441.1 μs 438.5 μs -0.6%
vesting-1 479.4 μs 471.4 μs -1.7%

@effectfully
Copy link
Contributor Author

Actually, thinking about it... The idea is trivial, but the implementation is some pretty annoying boilerplate, plus there are three ways to implement what's in here, all subtly different, all for 1.7% speedup that we'll get anyway if we just make ValueOf a data family. I'm now leaning on the side of closing this one. @michaelpj what do you think?

@michaelpj
Copy link
Contributor

Yeah, I'm happy to drop this.

@michaelpj michaelpj closed this Mar 22, 2022
@effectfully effectfully deleted the effectfully/builtins/inlinable-GEq branch March 22, 2022 14:35
@kwxm kwxm mentioned this pull request Jun 1, 2022
Merged
This was referenced Jan 18, 2023
Open
Merged
@effectfully effectfully restored the effectfully/builtins/inlinable-GEq branch July 29, 2024 19:03
@effectfully effectfully deleted the effectfully/builtins/inlinable-GEq branch July 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Builtins Evaluation Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effectfully @iohk-devops @michaelpj