Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden/QueryVersion1/CardanoNodeToClientVersion7 files #3241

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Jul 4, 2021

Fixes #3240.

See single commit's message.

@nfrisby nfrisby added consensus issues related to ouroboros-consensus testing labels Jul 4, 2021
@nfrisby nfrisby changed the title ouroboros-consensus-cardano-test: add golden/QueryVersion1/CardanoNodeToClientVersion7 files Add golden/QueryVersion1/CardanoNodeToClientVersion7 files Jul 4, 2021
…eToClientVersion7 files

These tests were added in PR #3220, but we forgot to add the expected files to
the repository. (A Golden test passes if there is no expected file to compared
against.)
@nfrisby nfrisby force-pushed the nfrisby/issue-3240-forgot-add-golden-files branch from 4bf7ee7 to 9b16e53 Compare July 6, 2021 15:55
@nfrisby
Copy link
Contributor Author

nfrisby commented Jul 6, 2021

Thanks, David. I rebased onto origin/master. No conflicts.

@nfrisby
Copy link
Contributor Author

nfrisby commented Jul 6, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 6, 2021

@iohk-bors iohk-bors bot merged commit 0b1b833 into master Jul 6, 2021
@iohk-bors iohk-bors bot deleted the nfrisby/issue-3240-forgot-add-golden-files branch July 6, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expected Golden test files for recently added QueryVersion1
2 participants