Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1732): fix reading property trim of nullish label #1824

Closed
wants to merge 1 commit into from
Closed

fix(#1732): fix reading property trim of nullish label #1824

wants to merge 1 commit into from

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Aug 26, 2024 •
edited
Loading

List of changes

  • fix reading property trim of nullish label

The issue originally is caused by an empty email in DRep detailed DRepDetailsInfoItem component. But email is not supported by CIP-119 property and should be removed within #1820

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Aug 26, 2024 that may be closed by this pull request
TypeError: Cannot read properties of null (reading 'trim') #1732
Closed
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@jdyczka
Copy link
Contributor

jdyczka commented Aug 26, 2024 •
edited
Loading

If it's caused by email, which will be removed, then I probably wouldn't accept undefined, because that doesn't make sense for data-testid

@jdyczka
Copy link
Contributor

jdyczka commented Aug 26, 2024

Anyway, issue number should be #1732

@MSzalowski MSzalowski changed the title fix(#1733): fix reading property trim of nullish label fix(#1732): fix reading property trim of nullish label Aug 26, 2024
@MSzalowski MSzalowski closed this Aug 26, 2024
@MSzalowski MSzalowski deleted the fix/1732-typeerror-cannot-read-properties-of-null-reading-trim branch August 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'trim')
2 participants
@MSzalowski @jdyczka