Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying modals to not block signing transactions with metadata #710

Closed
MSzalowski opened this issue Apr 12, 2024 · 1 comment · Fixed by #711
Closed

Fix displaying modals to not block signing transactions with metadata #710

MSzalowski opened this issue Apr 12, 2024 · 1 comment · Fixed by #711

Comments

@MSzalowski
Copy link
Contributor

Context & versions

  • dev-env
  • test-env

Steps to reproduce

Navigate to the flow that requires metadata:

  • Creating gov action.
  • DRep registration

Actual behavior

  • When validation ends no modal is displayed which causes either misunderstanding of what happens or completely blocks building the transaction.

Expected behavior

Modals are displayed correctly
@MSzalowski MSzalowski self-assigned this Apr 12, 2024
MSzalowski added a commit that referenced this issue Apr 12, 2024
@MSzalowski
[#710] fix displaying modals to not block signing transactions
b13a61d
MSzalowski added a commit that referenced this issue Apr 12, 2024
@MSzalowski
[#710] fix displaying modals to not block signing transactions
65d228d
@MSzalowski MSzalowski mentioned this issue Apr 12, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Apr 12, 2024 that will close this issue
[#710] fix displaying modals to not block signing transactions #711
Merged
5 tasks
MSzalowski added a commit that referenced this issue Apr 15, 2024
@MSzalowski
[#710] fix displaying modals to not block signing transactions
3266728
MSzalowski added a commit that referenced this issue Apr 16, 2024
@MSzalowski
Merge pull request #711 from IntersectMBO/fix/710-fix-displaying-moda…
411db90 
…ls-to-not-block-signing-transactions-with-metadata

[#710] fix displaying modals to not block signing transactions
@pmbinapps
Copy link

OK NOW

@pmbinapps pmbinapps mentioned this issue Apr 25, 2024
Merged
@MSzalowski MSzalowski removed their assignment May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#710] fix displaying modals to not block signing transactions IntersectMBO/govtool
2 participants
@MSzalowski @pmbinapps