Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA Display - Searching - full and partial search of GA id is not working #603

Closed
pmbinapps opened this issue Apr 2, 2024 · 1 comment · Fixed by #621
Closed

GA Display - Searching - full and partial search of GA id is not working #603

pmbinapps opened this issue Apr 2, 2024 · 1 comment · Fixed by #621
Assignees
@jankun4
Labels
🐛 Bug Something isn't working
Milestone
Byron - GA Displa...

Comments

@pmbinapps
Copy link

To reproduce:

  1. Go to https://test-sanchonet.govtool.byron.network/connected/governance_actions
  2. By typing to Search field try to ac55fbe465557d00bb1df360743d7ee086f0775e70a2468dfa0a3d812e166b5a#0
  3. Next remove some chars to a shorten string - item is not found

Compare with recording .

Searched item
@pmbinapps pmbinapps mentioned this issue Apr 2, 2024
Closed
@MSzalowski MSzalowski removed their assignment Apr 4, 2024
@MSzalowski
Copy link
Contributor

@jankun4 We should be able to search via gov action id

jankun4 added a commit that referenced this issue Apr 4, 2024
@jankun4
[#603] improve filter flexibility
7932316 
allow filtering GAs by their txHash and index

Signed-off-by: jankun4 <michaljankun@gmail.com>
@jankun4 jankun4 linked a pull request Apr 4, 2024 that will close this issue
[#603] improve filter flexibility #621
Merged
5 tasks
@pmbinapps pmbinapps added the 🐛 Bug Something isn't working label Apr 4, 2024
jankun4 added a commit that referenced this issue Apr 4, 2024
@jankun4
[#603] fix hlint errors
35fd4ec
MSzalowski added a commit that referenced this issue Apr 4, 2024
@MSzalowski
Merge pull request #621 from IntersectMBO/603-ga-display-searching-fu…
95dfcea 
…ll-and-partial-search-of-ga-id-is-not-working

[#603] improve filter flexibility
@pmbinapps pmbinapps mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankun4 jankun4

Labels
🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
Byron - GA Display: Search, Filter, a...
Development

Successfully merging a pull request may close this issue.

[#603] improve filter flexibility IntersectMBO/govtool
3 participants
@MSzalowski @jankun4 @pmbinapps