Merge pull request #1823 from IntersectMBO/fix/1733-typeerror-cannot-…

…read-properties-of-null-reading-drep_deposit fix(#1733): fix accessing drep deposit from possibly empty epoch params
IntersectMBO · Aug 26, 2024 · fe370fe · fe370fe
2 parents e48e960 + ef32b86
commit fe370fe
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ changes.
 ### Fixed
 
 - Fix typescript bug leading to runtime error when entering Governance Action details page via direct link [Issue 1801](https://github.com/IntersectMBO/govtool/issues/1801)
+- Fix accessing missing epochParams drep_deposit [Issue 1733](https://github.com/IntersectMBO/govtool/issues/1733)
 
 ### Changed
 

diff --git a/govtool/frontend/src/components/organisms/RegisterAsDRepSteps/RolesAndResponsibilities.tsx b/govtool/frontend/src/components/organisms/RegisterAsDRepSteps/RolesAndResponsibilities.tsx
@@ -20,7 +20,7 @@ export const RolesAndResponsibilities = ({
   const { t } = useTranslation();
   const { isMobile } = useScreenDimension();
 
-  const deposit = getItemFromLocalStorage(PROTOCOL_PARAMS_KEY);
+  const epochParams = getItemFromLocalStorage(PROTOCOL_PARAMS_KEY);
 
   const onClickContinue = () => setStep(2);
 
@@ -51,7 +51,7 @@ export const RolesAndResponsibilities = ({
             />,
           ]}
           i18nKey="registration.rolesAndResponsibilitiesDescription"
-          values={{ deposit: correctAdaFormat(deposit.drep_deposit) }}
+          values={{ deposit: correctAdaFormat(epochParams?.drep_deposit) }}
         />
       </Typography>
       <CenteredBoxBottomButtons

diff --git a/govtool/frontend/src/context/wallet.tsx b/govtool/frontend/src/context/wallet.tsx
@@ -651,14 +651,14 @@ const CardanoProvider = (props: Props) => {
           // Create cert object using one Ada as the deposit
           dRepRegCert = DrepRegistration.new_with_anchor(
             dRepCred,
-            BigNum.from_str(`${epochParams.drep_deposit}`),
+            BigNum.from_str(`${epochParams?.drep_deposit}`),
             anchor,
           );
         } else {
           console.error(t("errors.notUsingAnchor"));
           dRepRegCert = DrepRegistration.new(
             dRepCred,
-            BigNum.from_str(`${epochParams.drep_deposit}`),
+            BigNum.from_str(`${epochParams?.drep_deposit}`),
           );
         }
         return Certificate.new_drep_registration(dRepRegCert);

diff --git a/govtool/frontend/src/pages/RegisterAsDirectVoter.tsx b/govtool/frontend/src/pages/RegisterAsDirectVoter.tsx
@@ -131,7 +131,7 @@ export const RegisterAsDirectVoter = () => {
       >
         <Trans
           i18nKey="directVoter.registerDescription"
-          values={{ deposit: correctAdaFormat(epochParams.drep_deposit) }}
+          values={{ deposit: correctAdaFormat(epochParams?.drep_deposit) }}
           components={[
             <Link
               onClick={() => openInNewTab("https://sancho.network/")}