Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Plutus v1 reference scripts in Conway #4059

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Feb 8, 2024

Description

This PR removes a check from conway that fails a transaction when it's trying to use reference scripts for Plutus V1.

I also added support for reference scripts in ImpTests.

resolves #3965

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 7 times, most recently from fde565a to ea00f8a Compare February 9, 2024 13:23
@Soupstraw Soupstraw marked this pull request as ready for review February 9, 2024 13:23
@Soupstraw Soupstraw requested review from lehins and aniketd and removed request for lehins February 9, 2024 13:23
@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 4 times, most recently from 3dbf20b to 2fffd34 Compare February 9, 2024 14:13
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is close, but not quite done

@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 3 times, most recently from e26a23e to 605e5b1 Compare February 12, 2024 13:28
@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 9 times, most recently from 6277f31 to eaac007 Compare February 12, 2024 15:27
@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 3 times, most recently from 5411c36 to 2354dff Compare February 15, 2024 11:00
@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 2 times, most recently from 63b00a5 to ec40566 Compare February 15, 2024 11:40
@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 2 times, most recently from 123bf4b to 30b53e8 Compare February 15, 2024 13:50
@Soupstraw Soupstraw force-pushed the jj/plutusv1-refscripts branch 9 times, most recently from 01a2ef6 to c0ff559 Compare February 16, 2024 11:01
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect!!!! Thank you very much for this work.

@Soupstraw Soupstraw merged commit f754084 into master Feb 16, 2024
11 of 13 checks passed
@Soupstraw Soupstraw deleted the jj/plutusv1-refscripts branch February 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference scripts for PlutusV1
3 participants