Configuration/CLI preparation for HFC #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might want to consider adding |
The HFC/Cardano mode requires both a Byron genesis and a Shelley genesis files, so move the specification of these to the db-sync config file.
The Byron mainnet config has been tested, but Byron testnet has not. Also delete config for a component that has been moved out of this repo some time ago.
|
I personally like the socket path being explicit as I often switch around the path, so having to edit a file would be a pain. Obviously the right solution would be to have it in the config file and allow an optional CLI override, but that is significantly more work (ie testing) than I have time and patience for right now. |
rhyslbw
force-pushed
the
erikd/hfc-config
branch
from
e3a631f
to
0013dc7
Compare
…anges. BREAKING CHANGE: `--genesis-file` is no longer a CLI argument in the nixos service. The Docker image no longer establishes a pattern of conventional mount location for provided configuration and IPC socket, instead mount it where you wish and pass `--config` and `--socket-path` as the CMD. `--schema-dir` is set internally. This does not impact the mode of operation when selecting the IOHK-managed configuration via NETWORK env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.