Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerDes: Don't update registers if init failed #93

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

qingwuzh
Copy link
Collaborator

On some platforms, there isn't SerDes device.
Then don't want to update SerDes settings dynamically.

Signed-off-by: Qingwu Zhang qingwu.zhang@intel.com

Copy link
Collaborator

@xzhangxa xzhangxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check the return value of max9295_init_settings()/max9296_init_settings() in the probe functions to make it complete? Thanks.

@qingwuzh
Copy link
Collaborator Author

Could you also check the return value of max9295_init_settings()/max9296_init_settings() in the probe functions to make it complete? Thanks.

will check and print error in probe, but not break probe stage

@xzhangxa xzhangxa mentioned this pull request Mar 30, 2022
@ev-mp ev-mp changed the base branch from JetPack_4.6.1_baseline to master April 14, 2022 08:18
@ev-mp
Copy link
Collaborator

ev-mp commented Apr 14, 2022

@qingwuzh , please fix the patch number to be aligned with the current patches tree and confirm that this is functional (by powering off the deserializer)

On some platforms, there isn't SerDes device.
Then don't want to update SerDes settings dynamically.

Signed-off-by: Qingwu Zhang <qingwu.zhang@intel.com>
@qingwuzh
Copy link
Collaborator Author

@qingwuzh , please fix the patch number to be aligned with the current patches tree and confirm that this is functional (by powering off the deserializer)

Patch number had been updated.

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ev-mp ev-mp merged commit 603bb80 into IntelRealSense:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants