Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT feat: add fillers behaviour #1004

Open
wants to merge 3 commits into
base: 3.0
Choose a base branch
from
Open

DRAFT feat: add fillers behaviour #1004

wants to merge 3 commits into from

Conversation

Grafikart
Copy link
Collaborator

Add fillers behaviour

Fix #949

@Grafikart Grafikart requested a review from renaud23 May 16, 2024 10:38
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@laurentC35
Copy link
Contributor

We need to update this feature:

  • we are not respect REST convention, we have to use GET instead of POST
  • so we need to pass param directly to URL, URL need to be VTLified

We can check here, the implementation (with RemoteComponent, not the target...) : enable VTL en remote URL.

Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Grafikart
Copy link
Collaborator Author

I updated the behaviour to use GET instead of POST. To handle parameter I chose to allow VTL expression to compute the URL. Another solution would be to inject responses automatically but it would be less flexible.

{
	"endpoint": {
		"url": "\"https://inseefr.github.io/Lunatic/?code=\" || CODE",
		"type": "VTL"
	},
	"responses": [
		{
			"name": "CODE"
		}
	]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre remplissage de champs depuis un serveur
2 participants