bug fix: Parameters moved from root to Parameter Group is not handled correctly. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two bugs:
Parameter was not saved under following condition.
a) parameter was not owned by any parameter group at first.
b) parameter was moved to a parameter group in parameter panel.
First child of parameter group is not handled correctly, and cannot be removed from parameter group.
bug 1 was caused because unowned parameters are removed before added to ExParameterGroup before, but currently it must not be removed from puppet.parameters.
bug 2 was caused because first child was directly added to ExParameterGroup.children before, but now it have to be passed to moveParameter function.