Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace spawnShell() with browse() #152

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Replace spawnShell() with browse() #152

merged 2 commits into from
Apr 25, 2023

Conversation

scrwnl
Copy link
Contributor

@scrwnl scrwnl commented Dec 31, 2022

Console window no longer appears when opening a URL on Windows.

@scrwnl scrwnl changed the title Replace spawnShell() to browse() Replace spawnShell() with browse() Feb 2, 2023
@LunaTheFoxgirl
Copy link
Member

I haven't tested this yet, sorry...

@LunaTheFoxgirl LunaTheFoxgirl added the Needs verification Needs to be verified whether fixed or not label Apr 24, 2023
@LunaTheFoxgirl LunaTheFoxgirl added this to the 0.8 milestone Apr 24, 2023
@LunaTheFoxgirl
Copy link
Member

After checking, this should work so I'm merging it.

@LunaTheFoxgirl LunaTheFoxgirl removed the Needs verification Needs to be verified whether fixed or not label Apr 25, 2023
@LunaTheFoxgirl LunaTheFoxgirl merged commit 66b14be into Inochi2D:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Inochi2D Tasklist
Status: Done
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@scrwnl @LunaTheFoxgirl