Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue#266 cmdjlink permission denied #295

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

LinjingZhang
Copy link
Collaborator

@LinjingZhang LinjingZhang commented Aug 12, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
The download path creates permission problems if the Arduino IDE is installed for all users of Windows.

Related Issue
#266

Context
Store the intermediate jlink files in temporary folder to solve the permission problem.
This shoud work for all OS - test needed:

  • Windows

  • Linux

  • MacOS
    There were some problem with macOS:

  1. python path. https://forum.arduino.cc/t/esp32-problem-with-compilation-on-macos-12-3-monterey/969771/21
    so I changed "python" to "python3". for windows I kept "python"
  2. Jlink and java installation for macbook M2 (arm64). I wasted some time on downloading the correct package.

Copy link
Member

@OlafFilies OlafFilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok

@ederjc
Copy link
Member

ederjc commented Aug 16, 2024

Looks good to me. How did you test it so far?

@jaenrig-ifx
Copy link
Member

Yep, looks good 👍

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we before merge test it in linux and macos?

@LinjingZhang
Copy link
Collaborator Author

@ederjc @jaenrig-ifx
I will test it on LabPC / macbook, I have asked @OlafFilies for help😄
This problem is most likely windows-related, but I also would like to test on all os to check I didn't break anything.

@jaenrig-ifx
Copy link
Member

What is the deal with M2 macbooks?

- suppress traceback for Arduino IDE and - add more clear wrong COM message
- verbose(log) flag for xmc flasher script
- check if the upload is successful
@LinjingZhang LinjingZhang force-pushed the bugfix/issue#266_cmdjlink_permission_denied branch from f73ecc0 to 593cd19 Compare August 26, 2024 11:22
@LinjingZhang
Copy link
Collaborator Author

What is the deal with M2 macbooks?

I'm just unfamiliar with macbook myself 😿
Now tested on macOS. It works fine 😸

@LinjingZhang LinjingZhang merged commit e0d5503 into master Aug 27, 2024
16 checks passed
@LinjingZhang LinjingZhang deleted the bugfix/issue#266_cmdjlink_permission_denied branch August 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants