DESMAKERS-3827: enable 11/29Bits id frame send and receive #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaenrig-ifx
approved these changes
Jun 28, 2024
libraries/CAN/src/CANXMC.cpp
Outdated
| /* Configuration of CAN Node and enable the clock */ | ||
| #if (UC_FAMILY == XMC4) | ||
| #define CAN_CLOCK_SOURCE ((XMC_CAN_CANCLKSRC_t)XMC_CAN_CANCLKSRC_FPERI) | ||
| #define CAN_CLOCK_SOURCE ((XMC_CAN_CANCLKSRC_t)XMC_CAN_CANCLKSRC_FPERI) // synchronous clock for XMC4000 |
There was a problem hiding this comment.
All good, but if we have a lot of conditional compiling, in the future we have to check if some of these things might be better defined in the each board variant file...
There was a problem hiding this comment.
Yes, I agree - the XMC4000 and XMC1000 have some different settings. But also not board different... Maybe in the future a more reasonable set of variants could be considered
There was a problem hiding this comment.
maybe this should be defined in variants files
There was a problem hiding this comment.
I changed the variants files 😄
OlafFilies
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Now sendpacket() support both 11 & 29 bits identifier. same for receive.
Functions that are not the same as the official API can be removed, updating the README and example sketches.
Related Issue
N/A
Context
Once it's up and running, it works ;)