Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMC Arduino CAN Lib (Receiving) #270

Merged
merged 16 commits into from
Mar 27, 2024

Conversation

LinjingZhang
Copy link
Collaborator

@LinjingZhang LinjingZhang commented Mar 19, 2024

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Add CAN Arduino Library for XMC

Related Issue
Epic: DESMAKERS-3610

Context

  • Enable CAN receive function.

  • Test Examples:

libraries/CAN/examples/CANReceiver
libraries/CAN/examples/CANReceiverCallback

  • Refer to libraries/CAN/README_CAN.md for more about the details and the dirty work 😺

  • Commits about git-wiki release and debugger are also included. (sorry next time I will separate the PR 😜

    - local json index as template
    - change online help url
    - add .gitignore
- ! change macro CAN to CAN_xmc in xmclib !
- finisch initialization fuction
- update new struct for CAN and pin defines (XMC1400 2Go / XMC 4700 Relax kit
update Receiver example
- fix pipeline error
- update testdefines.ino and pin files
- Fix loops and callbacks
- Add README
cores/Arduino.h Outdated Show resolved Hide resolved
Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 😃 considering the red flag of xmc-libs mixing... This should be addressed with high priority after this enablement.

-  add license
- fix format
- change example
- macro
@LinjingZhang LinjingZhang changed the base branch from develop to feature/can_bus March 27, 2024 09:32
Copy link
Member

@ederjc ederjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please merge in feature/can_bus.
Before we merge in develop, we should ensure the following:

  • Unit test coverage
  • Proper hardware abstraction (e.g. #include <CAN.h> instead of CANXMC.h, no namespace ifx)
  • Update XMClib from 2.1.16 to 4.3.0 or latest in XMC for Arduino core to match version
  • Patch (CAN-> CAN_XMC) of XMClib needs to be automated

@ederjc ederjc closed this Mar 27, 2024
@ederjc ederjc reopened this Mar 27, 2024
@ederjc
Copy link
Member

ederjc commented Mar 27, 2024

Didn't see you changed the branch already, merging now 😄

@ederjc ederjc merged commit 7e82af6 into Infineon:feature/can_bus Mar 27, 2024
16 checks passed
@ederjc ederjc mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants