Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xmc flasher #261

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Fix xmc flasher #261

merged 4 commits into from
Jan 15, 2024

Conversation

boramonideep
Copy link
Contributor

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Fixing certain issues with the new XMC Flasher script

Copy link
Member

@OlafFilies OlafFilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far.
Question, this works now on all Python 3 minor versions, including the latest?

@boramonideep
Copy link
Contributor Author

boramonideep commented Jan 15, 2024

Looks good to me so far. Question, this works now on all Python 3 minor versions, including the latest?

Tested locally with 3.8, 3.9, 3.10, 3.11 and 3.12 (latest). For a thorough testing, we could use something like tox to test with more versions without installing all of them locally.

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectly working!

@boramonideep boramonideep merged commit 0709c2c into Infineon:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants