Add hosting of built wheel at PyPI - main #297
Conversation
for automated CDCI with pipit
|
by the way, when we eventually do merge this can we squash and merge? there's quite a lot of back and forth debugging for the GitHub actions which is quite messy. Thanks! |
|
Documentation heavily referenced building this btw. |
|
I just remembered, you can test your workflows using act. I have not used it before as we had self-hosted runners, but this repo uses the GitHub's runners so it should work |
ohh thanks for letting me know! next time I'll do away with all these trial and error commits 😂 |
|
Seems to be all working - fingers crossed this still works when we release our next version! Thanks for the review and kind suggestions @wong-hl, welcome (back) to SHARPy! 🤗 |
.github/workflows/readme.md
Outdated
| * `pypi_build_test.yaml`: Builds the pypi wheel but does not push. Runs on changes to the `pypi*` workflows, changes to the `utils/` directory (environments) and changes to the `setup.py`. Required test for PRs to merge to `develop` and `main`. | ||
| * `pypi_build.yaml`: Builds and pushes the pypi wheel. Runs on annotated tags. |
There was a problem hiding this comment.
ah right, yes!! thankss
There was a problem hiding this comment.
Works for me, great to see SHARPy being made even easier to install; assuming we have no issues after merging, we can change this to be the default method of installation. Be sure to squash before merging! I will await if Hui Ling has any further feedback, then we should be ready to merge. Great contribution!
kccwing
changed the title
|
seems to have a slight issue with submodule folder structure - installed sharpy wants to find libxbeam.so in /xbeam/lib/, but it should have been just in /xbeam/. |
Adding github actions to automatically release new wheel to PyPI on new version tag. Testing added for commits to prepare wheel sans upload. A few changes to setup.py necessitated to enable PyPI. Installation guide and github actions readme updated with (experimental!) documentation.