Multiple queued commands during watch #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgetall uses post_proc to make a dictionary from the results, check if it is called while two commands are sent when watching a key but before starting the multi part of the transaction.
If the connection is in a transaction but multi has not been called yet, treat post_proc as we would without a transaction.
fiorix
added a commit
that referenced
this pull request
Nov 21, 2014
Multiple queued commands during watch
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MULTI has not been called on a transaction yet, post_proc should be treated as it would be without a transaction.
Below is an example where post_proc won't be called. The result of hgetall will not be a dictionary:
This pull requests adds a test for this scenario, fixes the handling of post_proc before MULTI is called, and makes commit/discard check if MULTI is called.