Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SCAN commands. #71

Merged
merged 2 commits into from
Oct 20, 2014
Merged

Support for SCAN commands. #71

merged 2 commits into from
Oct 20, 2014

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Oct 2, 2014

Implemented SCAN/SSCAN/HSCAN/ZSCAN commands support.

@ioga
Copy link
Contributor Author

ioga commented Oct 2, 2014

By the way, main python redis library has a useful scan_iter method, but I cannot think of a good way to implement it in twisted given that python iterators don't play well with deferreds.

I can suggest two options:

  • implement scan_all method, which will return the list of all results, i.e. basically do the same as KEYS, but using a lot of SCAN commands.
  • scan_map method, which will accept a callable argument and execute it for every key.

Thoughts?

@ioga
Copy link
Contributor Author

ioga commented Oct 20, 2014

Any comment on this?

fiorix added a commit that referenced this pull request Oct 20, 2014
Support for SCAN commands.
@fiorix fiorix merged commit 2b59bc0 into IlyaSkriblovsky:master Oct 20, 2014
@fiorix
Copy link
Collaborator

fiorix commented Oct 20, 2014

LGTM

@fiorix
Copy link
Collaborator

fiorix commented Oct 20, 2014

Thanks!

@ioga ioga deleted the scan branch October 21, 2014 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants