Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detach method to IgxOverlay #6063

Closed
wnvko opened this issue Oct 25, 2019 · 4 comments · Fixed by #8823
Closed

Add detach method to IgxOverlay #6063

wnvko opened this issue Oct 25, 2019 · 4 comments · Fixed by #8823
Assignees
@wnvko @ViktorSlavov
Labels
overlay program: igniteui project management 🧰 feature-request version: 11.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Oct 25, 2019

Is your feature request related to a problem? Please describe.

Right now IgxOverlay has attach method. This method resolves the passed component and generates unique ID. Later on developer can show the overlay with provided ID.
However when developer calls hide method it resets the overlay for provided ID and this ID cannot be used anymore.
There should be detach method which should reset the overlay for provided ID. Hide method should only hide the overlay for provided ID without resetting the overlay.

Describe the solution you'd like

Add detach method.

Describe alternatives you've considered

One should call attach after each time hide was called. This forces overlay to resolve same component several times.
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 12, 2020
@wnvko wnvko removed the status: inactive Used to stale issues and pull requests label May 12, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jul 12, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Jul 12, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 11, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Sep 11, 2020
@Lipata Lipata assigned ViktorSlavov and unassigned wnvko and Lipata Oct 1, 2020
@Lipata Lipata mentioned this issue Oct 9, 2020
Closed
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Dec 2, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Dec 2, 2020
@wnvko wnvko self-assigned this Jan 11, 2021
@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 11, 2021
wnvko added a commit that referenced this issue Jan 21, 2021
@wnvko
test(overlay): fix combo related tests, #6063
a53b121
wnvko added a commit that referenced this issue Jan 21, 2021
@wnvko
test(overlay): fix combo related tests, #6063
50797bf
wnvko added a commit that referenced this issue Jan 22, 2021
@wnvko
test(overlay): fix date picker related tests, #6063
100f1c5
wnvko added a commit that referenced this issue Jan 22, 2021
@wnvko
test(overlay): fix drop down related tests, #6063
839bc70
wnvko added a commit that referenced this issue Jan 22, 2021
@wnvko
test(overlay): fix drop down related tests, #6063
faab6d4
@Lipata Lipata mentioned this issue Jan 28, 2021
Merged
14 tasks
@radomirchev radomirchev added the program: igniteui project management label Feb 8, 2021
@wnvko wnvko added ❌ status: awaiting-test PRs awaiting manual verification ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them ❌ status: awaiting-test PRs awaiting manual verification labels Mar 17, 2021
wnvko added a commit that referenced this issue Mar 31, 2021
@wnvko
test(overlay): fix background color test, #6063
034ba57
Lipata pushed a commit that referenced this issue Apr 2, 2021
@wnvko
feat(overlay): add detach method to overlay service #6063, #7088 (#8823)
ea82f1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wnvko wnvko

@ViktorSlavov ViktorSlavov

Labels
overlay program: igniteui project management 🧰 feature-request version: 11.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(overlay): add detach method to overlay service IgniteUI/igniteui-angular
4 participants
@Lipata @wnvko @ViktorSlavov @radomirchev