Refactor commit method of IgxHierarchicalTransactionService to accept same parameters as base type #5205
Labels
📈 enhancement
refactoring
🧰 feature-request
transaction
igxTransactionService
version: 10.0.x
✅ status: resolved
Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Is your feature request related to a problem? Please describe.
IgxHierarchicalTransactionService.commit
accepts three optional parameters -primaryKey
,childDataKey
andid
. In the same timeIgxTransactionService.commit
accepts only one optional parameter -id
. This is not ok, as both methods should have their parameters in the same order.Describe the solution you'd like
Remove
primaryKey
andchildDataKey
fromIgxHierarchicalTransactionService.commit
. These options could be passed in the constructor of the service or via public properties.The text was updated successfully, but these errors were encountered: