Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor commit method of IgxHierarchicalTransactionService to accept same parameters as base type #5205

Closed
wnvko opened this issue Jun 26, 2019 · 1 comment · Fixed by #7838
Assignees
Labels
📈 enhancement refactoring 🧰 feature-request transaction igxTransactionService version: 10.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Jun 26, 2019

Is your feature request related to a problem? Please describe.

IgxHierarchicalTransactionService.commit accepts three optional parameters - primaryKey, childDataKey and id. In the same time IgxTransactionService.commit accepts only one optional parameter - id. This is not ok, as both methods should have their parameters in the same order.

Describe the solution you'd like

Remove primaryKey and childDataKey from IgxHierarchicalTransactionService.commit. These options could be passed in the constructor of the service or via public properties.

@wnvko
Copy link
Contributor Author

wnvko commented Jul 21, 2020

We should create a new interface, e.g. HierarchicalTransactionService. In this new interface commit method should have two overloads:

public commit(data: any[], primaryKey: any, childDataKey: any, id?: any): void
public commit(data: any[], id?: any): void

IgxHierarchicalTransactionService should implement the new interface.

@valadzhov valadzhov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Jul 22, 2020
@wnvko wnvko removed their assignment Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 enhancement refactoring 🧰 feature-request transaction igxTransactionService version: 10.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants