Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[igx-nav-drawer][Sass] $border-radius doesn't change igxDrawerItem roundness. #4964

Closed
tkiryu opened this issue Jun 1, 2019 · 0 comments · Fixed by #5084
Closed

[igx-nav-drawer][Sass] $border-radius doesn't change igxDrawerItem roundness. #4964

tkiryu opened this issue Jun 1, 2019 · 0 comments · Fixed by #5084
Assignees
@simeonoff
Labels
📖 documentation nav-drawer sassdoc 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@tkiryu
Copy link

tkiryu commented Jun 1, 2019

Description

In order to change igxDrawerItem roundness, I set $border-radius to zero but it didn't work.

  • igniteui-angular version: 7.3.2
  • browser: N/A

Steps to reproduce

  1. Go to https://stackblitz.com/edit/igx-nav-drawer-item-border-radius-issue

Result

According to the igx-navdrawer-theme doc

$border-radius The border radius used for navdrawer item.

But the border radius of igxDrawerItem doesn't change. I assume that $border-radius is for igx-nav-drawer itself.

Expected result

  1. Doc should be fixed like this.

$border-radius The border radius used for navdrawer component.

  1. $item-border-radius should be added to change border radius of igxDrawerItem like $igx-list-theme

Attachments

https://stackblitz.com/edit/igx-nav-drawer-item-border-radius-issue
@tkiryu tkiryu added the 🐛 bug Any issue that describes a bug label Jun 1, 2019
@simeonoff simeonoff added 🧰 feature-request and removed 🐛 bug Any issue that describes a bug labels Jun 19, 2019
simeonoff added a commit that referenced this issue Jun 19, 2019
@simeonoff
feat(navdrawer): allow setting border radius for navdrawer items
01c90ed 
Closes #4964
This was referenced Jun 19, 2019
Closed
Merged
@simeonoff simeonoff added the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

Labels
📖 documentation nav-drawer sassdoc 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
3 participants
@kdinev @simeonoff @tkiryu