Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample(grid): Add export visualiuzation sample #2233

Merged
merged 8 commits into from
Sep 8, 2020
Merged

sample(grid): Add export visualiuzation sample #2233

merged 8 commits into from
Sep 8, 2020

Conversation

astaev
Copy link
Contributor

@astaev astaev commented Aug 31, 2020 •
edited
Loading

Closes #2212

@astaev astaev marked this pull request as ready for review September 2, 2020 10:49
@astaev astaev assigned astaev and onlyexeption and unassigned astaev Sep 2, 2020
DiyanDimitrov
DiyanDimitrov suggested changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@DiyanDimitrov DiyanDimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove hierarchical grid sample since we do not officially support exporting for hierarchical grid.
  2. Add some margin in the sample so the grid border shadow is not cut off in docfx.
  3. Since the CSV export is faster, the exporting indicator does not appear when exporting to CSV. We should either disable the CSV export or additionally increase the amount of data.

src/app/grid/grid-export-visualization/grid-export-visualization.component.html Outdated Show resolved Hide resolved
live-editing/configs/GridConfigGenerator.ts Outdated Show resolved Hide resolved
src/app/grid/grid-export-visualization/grid-export-visualization.component.html Outdated Show resolved Hide resolved
src/app/tree-grid/tree-grid-export-visualization/tree-grid-export-visualization.component.html Outdated Show resolved Hide resolved
@onlyexeption
Copy link
Contributor

I verified the PR but you have lint errors to fix.

@astaev
Copy link
Contributor Author

astaev commented Sep 4, 2020

I verified the PR but you have lint errors to fix.
https://dev.azure.com/IgniteUI/igniteui-angular/_build/results?buildId=25335&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=59a85588-b0ba-5043-24c4-d9e29d89c6f6
Lint step at the build result is green.

@onlyexeption
Copy link
Contributor

I verified the PR but you have lint errors to fix.
https://dev.azure.com/IgniteUI/igniteui-angular/_build/results?buildId=25335&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=59a85588-b0ba-5043-24c4-d9e29d89c6f6
Lint step at the build result is green.

Oops, my bad. I commented on the wrong PR.

@DiyanDimitrov DiyanDimitrov merged commit f61acee into vNext Sep 8, 2020
@DiyanDimitrov DiyanDimitrov deleted the astaev/gridExportingVisualization branch September 8, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

Assignees

@onlyexeption onlyexeption

Labels
grid hierarchical-grid status: verified tree-grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astaev @onlyexeption @DiyanDimitrov