Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cross-rs build #939

Merged
merged 77 commits into from
Aug 11, 2024
Merged

ci: add cross-rs build #939

merged 77 commits into from
Aug 11, 2024

Conversation

vnghia
Copy link
Contributor

@vnghia vnghia commented Aug 1, 2024

Fixes #951.

@vnghia vnghia marked this pull request as draft August 1, 2024 13:49
@vnghia vnghia closed this Aug 1, 2024
@IgnisDa
Copy link
Owner

IgnisDa commented Aug 1, 2024

Hi! Was this closed by mistake?

@vnghia vnghia reopened this Aug 6, 2024
@vnghia
Copy link
Contributor Author

vnghia commented Aug 6, 2024

@IgnisDa, please test the latest ghcr.io/vnghia/ryot:test, feel free to edit the PR and ping me if you need help

@IgnisDa
Copy link
Owner

IgnisDa commented Aug 6, 2024

image

It does not seem to be working on my macbook.

@IgnisDa
Copy link
Owner

IgnisDa commented Aug 6, 2024

It is working fine on My server which is x86.

Copy link
Owner

@IgnisDa IgnisDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I think the old docker file and release workflow can be removed too.

.github/workflows/main.yaml Outdated Show resolved Hide resolved
@IgnisDa
Copy link
Owner

IgnisDa commented Aug 6, 2024

Also since you have been so helpful in contributing, I want to give you a pro key for free. Just drop me a DM on the discord if you want it. Link is in the readme.

@IgnisDa
Copy link
Owner

IgnisDa commented Aug 8, 2024

@vnghia any updates on this?

@IgnisDa IgnisDa mentioned this pull request Aug 8, 2024
ci/cross/Dockerfile.aarch64 Outdated Show resolved Hide resolved
@IgnisDa
Copy link
Owner

IgnisDa commented Aug 10, 2024

The Debian bookworm we are using as the final image only has libssl3 and not libssl1.1. The final solutions I came up with is to manually install libssl1.1 from the previous version packages. This is the disvantage of dynamically linking, you have to make sure that the shared library is the same for both compiling and running phase.

@vnghia Will it help to get rid of all the manual installations if we use some other image as the base? I can definitely see the current Dockerfile becoming too complex for me to wrap my head around.

Dockerfile Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
@IgnisDa IgnisDa merged commit 161e0e7 into IgnisDa:main Aug 11, 2024
9 checks passed
@vnghia vnghia deleted the ci branch August 11, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ryot crash since 6.9.3
2 participants