Upgrade Android dependencies #820
Conversation
|
Looks like there are some strange errors when building SDKs (noAPI should be fine) https://github.com/Igalia/wolvic/actions/runs/5483543167/jobs/9989998898?pr=820 |
|
HvrArm64Gecko build is OK on my computer, here the error is |
|
Get it fixed by increasing the Java maximum size of the memory allocation pool |
There was a problem hiding this comment.
One of the most amazing changesets I've reviewed lately. Keep up the good job! I'm actually quite surprised that everything builds fine after those changes.
We should be supercareful and enhance QA anyway, because there might be breaking changes/regressions.
I just have some minor nits
app/src/common/shared/com/igalia/wolvic/ui/adapters/Bookmark.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/browser/LoginStorage.kt
Outdated
Show resolved
Hide resolved
HollowMan6
force-pushed
the
deprecated
branch
3 times, most recently
from
fbe3ec0
to
21f187d
Compare
HollowMan6
force-pushed
the
deprecated
branch
2 times, most recently
from
8819496
to
046b6ba
Compare
|
The upgrade is harder than I previously anticipated. Looks like a lot of things have been broken with this PR (bookmarks, history, extensions ...) Will try to fix those as well. This needs more time. |
HollowMan6
force-pushed
the
deprecated
branch
2 times, most recently
from
79f1ada
to
80b4d89
Compare
|
Looks like many breaking changes were made during Gecko/Android Component 105->106 upgrades, as I can fix those bookmarks, history, and extensions ... breaks by downgrading to 105 |
HollowMan6
force-pushed
the
deprecated
branch
3 times, most recently
from
92d4dec
to
b6529aa
Compare
Ah OK, that makes more sense :). We tried this upgrade in the past and it was not trivial at all. That's why I was amazed because I thought the upgrade didn't bring regressions. Yeah, let's go step by step as we are not in a hurry |
|
I think we are now ready. Looks like the upgrade doesn't bring regressions now.
|
HollowMan6
force-pushed
the
deprecated
branch
2 times, most recently
from
0c0f680
to
4af6dce
Compare
HollowMan6
force-pushed
the
deprecated
branch
2 times, most recently
from
9b426de
to
533a40f
Compare
- Android Component to 105.0.8 - We are not ready to land on android_gradle_plugin 8 because some of the deprecated method used in com.huawei.agconnect:agcp. - Increase the Java maximum size of the memory allocation pool to 4g, so that HvrArm64Gecko build failure with ERROR:R8: java.lang.OutOfMemoryError: Java heap space in CI can be fixed - Use JDK 17 and Gradle 7.5 in CI Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
So that we can focus on specific API failures in CI Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
- Fragment in android.app was deprecated in API level 28: Use the Jetpack Fragment Library Fragment for consistent behavior across all devices and access to Lifecycle. - FragmentTransaction in android.app was deprecated in API level 28. Use the Support Library FragmentTransaction. - getFragmentManager() has been removed in favor of getParentFragmentManager() which throws an IllegalStateException if the FragmentManager is null. - BaseBundle.get was deprecated in API level 33. Use the type-safe specific APIs depending on the type of the item to be retrieved Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Partially fixes #802 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
This PR upgrades Android dependencies as newest as possible. The compileSdkVersion is now 33 because of the dependency needs. Some of the dependencies are not upgraded to the latest due to the following build errors (WARNING: I still haven’t got my VR device, so I didn’t tried to test the functionality. I can only ensure that it builds successfully):
We are also not ready to land on android_gradle_plugin 8 because some of the deprecated method used in com.huawei.agconnect:agcp.
Also I fixed the CMake version to 3.10.2 because of the nature of the CMakeList.txt in project.