Search in Library sections #1566
Open
+174
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a search bar for Bookmarks, History, and Downloads. Each view keeps a cached version of the list of items. When the user enters a search term, we filter this cached list and update the Adapter. This avoids having to query the backend each time. Currently this implementation updates the search results as the user types each character, but if this does not have good performance we can change it later on. There is a change to the OnScrollListener to ensure that the RecyclerView only requests the focus when it scrolls as a result of user interaction, which will close the on-screen keyboard.
Set the "overScrollMode" to "never" by default and remove those instances where it had been manually set.
Remove CustomLinearLayoutManager, a workaround for an old bug in the RecyclerView library and which is no longer necessary.
svillar
requested changes
Oct 8, 2024
| @@ -122,6 +123,22 @@ public void onDestroy() { | |||
| mBinding.downloadsList.removeOnScrollListener(mScrollListener); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean supportsSearch() { | |||
There was a problem hiding this comment.
This repetition of the same pattern in all the views makes me wonder why we don't move everything to the LibraryView class.
| @@ -56,7 +56,6 @@ | |||
| android:layout_marginEnd="20dp" | |||
| android:divider="@android:color/transparent" | |||
| android:smoothScrollbar="true" | |||
| android:overScrollMode="never" | |||
There was a problem hiding this comment.
I guess the question here is why. There is no explanation why we are doing that.
There was a problem hiding this comment.
Always nice to remove code, but can we add a reference to the old bug that is no longer needed? Or a reference to the PR that added it, we need traceability here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a search bar for Bookmarks, History, and Downloads.
Each of these views keeps a cached version of the list of items. When the user enters a search term, we filter this cached list and update the Adapter. This avoids having to query the backend each time.
Currently this implementation updates the search results as the user types each character, but if this does not have good performance we can change it later on.
There is a change to the OnScrollListener to ensure that the RecyclerView only requests the focus when it scrolls as a result of user interaction, which will close the on-screen keyboard.
This PR also contains a couple of related changes to our RecyclerView lists.
First, we set the
overScrollModetoneverby default and remove those instances where it had been manually set. This removes the bouncing rubber band effect when scrolling the list.Secondly, we remove
CustomLinearLayoutManager, a workaround for an old bug in the RecyclerView library which is no longer necessary.