Improve Device Name in Firefox/Mozilla Sync #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
reviewed
Oct 20, 2023
svillar
reviewed
Oct 20, 2023
HollowMan6
force-pushed
the
device-name
branch
from
5e2d306
to
b088379
Compare
svillar
approved these changes
Oct 27, 2023
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/FxAAccountOptionsView.java
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/FxAAccountOptionsView.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/FxAAccountOptionsView.java
Outdated
Show resolved
Hide resolved
HollowMan6
force-pushed
the
device-name
branch
3 times, most recently
from
fac6f26
to
041adc0
Compare
svillar
approved these changes
Oct 30, 2023
Use the pre-defined device name according to device type. If the device type is unknown (i.e. no-api), use Build.MANUFACTURER + " " + Build.MODEL as fall back. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
Resolve #1069 Signed-off-by: Songlin Jiang <sjiang@igalia.com>
So that we don't need to scroll for device name in accounts settings. Signed-off-by: Songlin Jiang <sjiang@igalia.com>
HollowMan6
force-pushed
the
device-name
branch
from
32e455c
to
5d631ca
Compare
|
I just fixed the rebase error @svillar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the pre-defined device name according to device type. If the device type is unknown (i.e. no-api), use Build.MANUFACTURER + " " + Build.MODEL as fall back.
So that we don't need to scroll for newly added haptic feedback in controllers settings in Enable haptic feedback for controllers #1068 and device name in accounts settings.
Resolves #1069
