Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable seeking VR video through controller D-pad #1063

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Enable seeking VR video through controller D-pad #1063

merged 1 commit into from
Oct 17, 2023

Conversation

HollowMan6
Copy link
Collaborator

com.igalia.wolvic-20231013-011956.mp4

@HollowMan6
Enable seeking VR video through controller D-pad
d60a57b 
Signed-off-by: Songlin Jiang <sjiang@igalia.com>
javifernandez
javifernandez approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@javifernandez javifernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good overall; I've just added some code style suggestion for you to consider that that doesn't affect the functionality of your PR.

app/src/common/shared/com/igalia/wolvic/VRBrowserActivity.java Show resolved Hide resolved
@HollowMan6 HollowMan6 mentioned this pull request Oct 13, 2023
Merged
@HollowMan6 HollowMan6 merged commit 58720a7 into main Oct 17, 2023
18 checks passed
@HollowMan6 HollowMan6 deleted the controller-seek branch October 17, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javifernandez javifernandez javifernandez approved these changes

@felipeerias felipeerias Awaiting requested review from felipeerias

@svillar svillar Awaiting requested review from svillar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HollowMan6 @javifernandez