Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan: Streamline vendor file location with local dev-env #130

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

raviks789
Copy link
Contributor

phpstan is not run with an action anymore, as the action runs it its own docker container and hence has no access to files outside the repository root. A side-effect of this is, that phpstan now really runs with the php version set up by the matrix.

@raviks789 raviks789 self-assigned this Feb 12, 2024
@cla-bot cla-bot bot added the cla/signed label Feb 12, 2024
@raviks789 raviks789 force-pushed the phpstan-streamline-vendor-location branch 2 times, most recently from a22b319 to 5924717 Compare February 12, 2024 15:24
phpstan is not run with an action anymore, as the action runs it its own docker container and hence
has no access to files outside the repository root. A side-effect of this is, that phpstan now
**really** runs with the php version set up by the matrix.
@raviks789 raviks789 force-pushed the phpstan-streamline-vendor-location branch from 5924717 to f89d29f Compare February 12, 2024 15:25
@raviks789 raviks789 marked this pull request as draft February 12, 2024 15:55
@raviks789 raviks789 removed the request for review from nilmerg February 12, 2024 15:55
@raviks789 raviks789 marked this pull request as ready for review February 12, 2024 16:41
@nilmerg nilmerg merged commit 2734a18 into main Feb 13, 2024
7 checks passed
@nilmerg nilmerg deleted the phpstan-streamline-vendor-location branch February 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants